630542 - Regression: Context menus do not pop up on links

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b10pre) Gecko/20100201 Firefox/4.0b10pre Fennec/4.0b4pre

Steps to Reproduce:
1. Go to bugzilla.mozilla.org
2. Tap and hold on one of the bugzilla icons

Actual Results:
Context menu does not pop up

Expected Results:
Context menu pops up

Comment 1

[Aakash Desai [:aakashd]]

This is working on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:2.0b11pre) Gecko/20110131 Firefox/4.0b11pre Fennec/4.0b5pre ID:20110131120454

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Regression from bug 630145. The code must be throwing an exception which stops the rest of the content.js file objects from initializing.

Firefox desktop wraps this in a try/catch, now we do too.

Comment 3

[Benjamin Stover (:stechz)]

Assigning bug to myself at the request of Mark.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

useGlobalHistory will init the nsIGlobalHistory2 service, which is actually, nsNavHistory.cpp and that tries to do something and fails

Comment 5

[Benjamin Stover (:stechz)]

Comment on attachment 508808 [details] [diff] [review]
patch

r+ with a followup to remove try-catch in bug 630593.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/6987c7f6e252

Comment 7

[Andreea Pod]

Verified on build: Mozilla /5.0 (Android;Linux armv7l;rv:2.2a1pre)
Gecko/20110406 Firefox/4.2a1pre Fennec /4.1a1pre 
Device: Samsung Captivate (Android 2.2 update 1)