Add NPAPI plugin check to validator

VERIFIED FIXED in 5.12.10

Status

addons.mozilla.org Graveyard
Developer Pages
P3
enhancement
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: jorgev, Assigned: basta)

Tracking

unspecified
5.12.10

Details

(Whiteboard: [ReviewTeam])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
This was suggested by an add-on author, and I think it's a good idea, given that we almost always reject add-ons that include NPAPI plugins.

What to look for:
The add-on has a "plugins" directory in the root of the package, with at least one DLL file in it. Only extensions can have this.

What to do:
Show a warning with the following message: NPAPI plugins are generally not allowed in extensions. The only approved channel for plugins is the Plugin Finder Service.
(Assignee)

Comment 1

8 years ago
Should I show an error if there is a plugins directory with DLLs and the add-on is *not* an extension?
(Reporter)

Comment 2

8 years ago
It's not necessary. A DLL in a non-extension should be enough to raise several flags with editors.
(Assignee)

Comment 3

8 years ago
Done:

https://github.com/mattbasta/amo-validator/commit/abb089d969c3664623c35b6facaea78ce76cc727
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 4

8 years ago
Should this be up on preview already? This page doesn't show the new warning:
https://addons.allizom.org/en-US/developers/addon/bitdefender-quickscan/file/103054/validation
(Assignee)

Comment 5

8 years ago
Kumar hasn't said anything and this is one of the most recent things that I've pushed, so it probably isn't.

Comment 8

8 years ago
Created attachment 511436 [details]
post-fix screenshot
Bumping to .10, this didn't have any bake time so it missed .9.
Target Milestone: 5.12.9 → 5.12.10
(Reporter)

Comment 10

7 years ago
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.