630555 - Add NPAPI plugin check to validator

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, enhancement, P3)

Description

[Jorge Villalobos [:jorgev] (he/him)]

This was suggested by an add-on author, and I think it's a good idea, given that we almost always reject add-ons that include NPAPI plugins.

What to look for:
The add-on has a "plugins" directory in the root of the package, with at least one DLL file in it. Only extensions can have this.

What to do:
Show a warning with the following message: NPAPI plugins are generally not allowed in extensions. The only approved channel for plugins is the Plugin Finder Service.

Comment 1

[Matt Basta [:basta]]

Should I show an error if there is a plugins directory with DLLs and the add-on is *not* an extension?

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

It's not necessary. A DLL in a non-extension should be enough to raise several flags with editors.

Comment 3

[Matt Basta [:basta]]

Done:

https://github.com/mattbasta/amo-validator/commit/abb089d969c3664623c35b6facaea78ce76cc727

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

Should this be up on preview already? This page doesn't show the new warning:
https://addons.allizom.org/en-US/developers/addon/bitdefender-quickscan/file/103054/validation

Comment 5

[Matt Basta [:basta]]

Kumar hasn't said anything and this is one of the most recent things that I've pushed, so it probably isn't.

Comment 6

[Kumar McMillan [:kumar]]

Whoops, just saw this.  Pushed to Zamboni in https://github.com/jbalogh/zamboni-lib/commit/2affece

Comment 7

[krupa raj[:krupa]]

verified fixed @ https://addons-next.allizom.org/en-US/developers/upload/8a017613e2d24a85a3711ae9400f6f09

Comment 8

[krupa raj[:krupa]]

Attachment: post-fix screenshot

Comment 9

[Jeff Balogh (:jbalogh)]

Bumping to .10, this didn't have any bake time so it missed .9.

Comment 10

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...