Closed
Bug 630593
Opened 12 years ago
Closed 12 years ago
DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory
Categories
(Core Graveyard :: History: Global, defect)
Core Graveyard
History: Global
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stechz, Assigned: stechz)
Details
Attachments
(2 files, 1 obsolete file)
964 bytes,
patch
|
bzbarsky
:
review+
sdwilsh
:
feedback+
mfinkle
:
approval2.0+
|
Details | Diff | Splinter Review |
4.12 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
The error: Exception... "Component returned failure code: 0x8007000e (NS_ERROR_OUT_OF_MEMORY) [nsIDocShellHistory.useGlobalHistory]" nsresult: "0x8007000e (NS_ERROR_OUT_OF_MEMORY)" location: "JS frame :: chrome://browser/content/content.js :: init :: line 258" data: no] I don't think this error is related to memory.
Assignee | ||
Comment 1•12 years ago
|
||
We discovered this in Fennec: https://bugzilla.mozilla.org/show_bug.cgi?id=630542. According to mfinkle the error seems to happen here: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavHistory.cpp#413
Assignee | ||
Updated•12 years ago
|
Summary: DocShell history gives NS_ERROR_OUT_OF_MEMORY → DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory
Assignee | ||
Comment 2•12 years ago
|
||
I think we just need to IPCize the useGlobalHistory code to not init nsNavHistory.
Comment 3•12 years ago
|
||
More likely: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavHistory.cpp#1163 or : http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavHistory.cpp#453 The prefs service should work fine in the child process
Comment 4•12 years ago
|
||
Bug 630542 landed. We can revert it when this fix lands.
Assignee | ||
Comment 5•12 years ago
|
||
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 508821 [details] [diff] [review] DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory Since the child process will not have nsNavHistory and Firefox/Fennec do not use it in docshell anyway, there is no need for the success of useGlobalHistory to be dependent on nsNavHistory init in this case. With nsNavHistory out of the way, this fixes the errors for me.
Attachment #508821 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 7•12 years ago
|
||
Updated•12 years ago
|
Attachment #508821 -
Flags: feedback+
![]() |
||
Comment 8•12 years ago
|
||
Comment on attachment 508821 [details] [diff] [review] DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory Looks good.
Attachment #508821 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #508825 -
Flags: review?(mark.finkle)
Updated•12 years ago
|
Attachment #508825 -
Flags: review?(mark.finkle) → review+
Comment 9•12 years ago
|
||
Comment on attachment 508821 [details] [diff] [review] DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory Ben - Can you wipe up a small browser-chrome test in mobile-browser to make sure the history is actually being used. We should be able to steal something from the places tests to make a small test.
Attachment #508821 -
Flags: approval2.0+
Assignee | ||
Comment 10•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #511111 -
Flags: review?(mark.finkle)
Assignee | ||
Updated•12 years ago
|
Attachment #508825 -
Attachment is obsolete: true
Updated•12 years ago
|
Attachment #511111 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 11•12 years ago
|
||
Pushed m-c: http://hg.mozilla.org/mozilla-central/rev/bfee8745b4bd Pushed m-b: http://hg.mozilla.org/mobile-browser/rev/b456c11f2f37
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•