Closed Bug 630593 Opened 9 years ago Closed 9 years ago

DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory

Categories

(Core Graveyard :: History: Global, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stechz, Assigned: stechz)

Details

Attachments

(2 files, 1 obsolete file)

The error:

Exception... "Component returned failure code: 0x8007000e (NS_ERROR_OUT_OF_MEMORY) [nsIDocShellHistory.useGlobalHistory]"  nsresult: "0x8007000e (NS_ERROR_OUT_OF_MEMORY)"  location: "JS frame :: chrome://browser/content/content.js :: init :: line 258"  data: no]

I don't think this error is related to memory.
Summary: DocShell history gives NS_ERROR_OUT_OF_MEMORY → DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory
I think we just need to IPCize the useGlobalHistory code to not init nsNavHistory.
Bug 630542 landed. We can revert it when this fix lands.
Comment on attachment 508821 [details] [diff] [review]
DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory

Since the child process will not have nsNavHistory and Firefox/Fennec do not use it in docshell anyway, there is no need for the success of useGlobalHistory to be dependent on nsNavHistory init in this case.

With nsNavHistory out of the way, this fixes the errors for me.
Attachment #508821 - Flags: review?(bzbarsky)
Attached patch Remove try catch (obsolete) — Splinter Review
Attachment #508821 - Flags: feedback+
Comment on attachment 508821 [details] [diff] [review]
DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory

Looks good.
Attachment #508821 - Flags: review?(bzbarsky) → review+
Attachment #508825 - Flags: review?(mark.finkle)
Attachment #508825 - Flags: review?(mark.finkle) → review+
Comment on attachment 508821 [details] [diff] [review]
DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory

Ben - Can you wipe up a small browser-chrome test in mobile-browser to make sure the history is actually being used. We should be able to steal something from the places tests to make a small test.
Attachment #508821 - Flags: approval2.0+
Attachment #511111 - Flags: review?(mark.finkle)
Attachment #508825 - Attachment is obsolete: true
Attachment #511111 - Flags: review?(mark.finkle) → review+
Pushed m-c: http://hg.mozilla.org/mozilla-central/rev/bfee8745b4bd
Pushed m-b: http://hg.mozilla.org/mobile-browser/rev/b456c11f2f37
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → ben
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.