630593 - DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory

Status: RESOLVED FIXED

(Core Graveyard :: History: Global, defect)

Description

[Benjamin Stover (:stechz)]

The error:

Exception... "Component returned failure code: 0x8007000e (NS_ERROR_OUT_OF_MEMORY) [nsIDocShellHistory.useGlobalHistory]"  nsresult: "0x8007000e (NS_ERROR_OUT_OF_MEMORY)"  location: "JS frame :: chrome://browser/content/content.js :: init :: line 258"  data: no]

I don't think this error is related to memory.

Comment 1

[Benjamin Stover (:stechz)]

We discovered this in Fennec: https://bugzilla.mozilla.org/show_bug.cgi?id=630542.

According to mfinkle the error seems to happen here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavHistory.cpp#413

Comment 2

[Benjamin Stover (:stechz)]

I think we just need to IPCize the useGlobalHistory code to not init nsNavHistory.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

More likely: 
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavHistory.cpp#1163

or :
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavHistory.cpp#453

The prefs service should work fine in the child process

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Bug 630542 landed. We can revert it when this fix lands.

Comment 5

[Benjamin Stover (:stechz)]

Attachment: DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory

Comment 6

[Benjamin Stover (:stechz)]

Comment on attachment 508821 [details] [diff] [review]
DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory

Since the child process will not have nsNavHistory and Firefox/Fennec do not use it in docshell anyway, there is no need for the success of useGlobalHistory to be dependent on nsNavHistory init in this case.

With nsNavHistory out of the way, this fixes the errors for me.

Comment 7

[Benjamin Stover (:stechz)]

Attachment: Remove try catch

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 508821 [details] [diff] [review]
DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory

Looks good.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 508821 [details] [diff] [review]
DocShell history gives NS_ERROR_OUT_OF_MEMORY for useGlobalHistory

Ben - Can you wipe up a small browser-chrome test in mobile-browser to make sure the history is actually being used. We should be able to steal something from the places tests to make a small test.

Comment 10

[Benjamin Stover (:stechz)]

Attachment: Remove try/catch and test for saving history

Comment 11

[Benjamin Stover (:stechz)]

Pushed m-c: http://hg.mozilla.org/mozilla-central/rev/bfee8745b4bd
Pushed m-b: http://hg.mozilla.org/mobile-browser/rev/b456c11f2f37

Comment 12

[Dão Gottwald [::dao]]

bugspam