Closed Bug 630594 Opened 9 years ago Closed 9 years ago

Click delay should be disabled if the page is not zoomable

Categories

(Firefox for Android Graveyard :: General, defect, P2)

defect

Tracking

(fennec2.0+)

VERIFIED FIXED
Tracking Status
fennec 2.0+ ---

People

(Reporter: paul, Assigned: mbrubeck)

References

Details

Attachments

(1 file, 1 obsolete file)

If I'm right, before firing the "click" event, we wait 400ms to make sure it's not a double-click. Double-click is used to zoom on a webpage. If the meta viewport doesn't allow zoom, we should not wait 400ms.
tracking-fennec: --- → ?
Priority: -- → P2
Attached patch Patch (obsolete) — Splinter Review
Mark, things feel faster when you click anywhere on the about:home page with this patch.
Attachment #510575 - Flags: review?(mark.finkle)
Assignee: nobody → 21
tracking-fennec: ? → 2.0b5+
tracking-fennec: 2.0b5+ → 2.0+
Just an FYI--this is blocking a mobile demo for Fx 4 Mobile release, runfield. 

CC-ing clooney and thomas.
Blocks: 600772
Comment on attachment 510575 [details] [diff] [review]
Patch

nit: } else {

I'm wondering if this is the best place to put the code. I guess it's OK for now.
Attachment #510575 - Flags: review?(mark.finkle) → review+
(In reply to comment #3)
> Comment on attachment 510575 [details] [diff] [review]
> Patch
> 
> nit: } else {
> 
> I'm wondering if this is the best place to put the code. I guess it's OK for
> now.

What do you mean? Do you want to move it inside the tapUp method or what?
(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 510575 [details] [diff] [review]
> > Patch
> > 
> > nit: } else {
> > 
> > I'm wondering if this is the best place to put the code. I guess it's OK for
> > now.
> 
> What do you mean? Do you want to move it inside the tapUp method or what?

Not sure. It just seems a bit out of place here. Feel free to land this. I can think more about it and file a new bug later, if needed.
This should be efficient in tomorrow's nightly.

http://hg.mozilla.org/mobile-browser/rev/fc4b66851459
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Where is the location of the mobile demo? I'd like to verify this bug.
Depends on: 633539
Backed out because of bug 633539:
http://hg.mozilla.org/mobile-browser/rev/eaf417128996
Assignee: 21 → mbrubeck
Status: RESOLVED → REOPENED
OS: Linux → All
Hardware: x86 → All
Resolution: FIXED → ---
Attached patch patchSplinter Review
Simple change to pass along whether the tapUp is a click or a pan.
Attachment #510575 - Attachment is obsolete: true
Attachment #511766 - Flags: review?(21)
http://hg.mozilla.org/mobile-browser/rev/76bd4e6c558f
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Comment on attachment 511766 [details] [diff] [review]
patch

We could look at using UIEvents and event.detail for passing this kind of data too.
(In reply to comment #7)
> Where is the location of the mobile demo? I'd like to verify this bug.

asking for this again, thanks.
Thanks Paul.   I've compared the demo on the 20110316 build versus 20110209 build, and the older build seems much more noticably delayed onClick.  However, the newer build still seems to exhibit a shorter delay, and not as snappy as desktop builds.

Paul ,can you give it a try and see if this fixes your original problem?   in my mind, its much better, but not 100% responsive as i would have expected.
It's much much much better. Perfect.
I don't see how it could be more responsive.
Marking verified fixed then, based on comment 15.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.