630594 - Click delay should be disabled if the page is not zoomable

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Paul Rouget [:paul]]

If I'm right, before firing the "click" event, we wait 400ms to make sure it's not a double-click. Double-click is used to zoom on a webpage. If the meta viewport doesn't allow zoom, we should not wait 400ms.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Mark, things feel faster when you click anywhere on the about:home page with this patch.

Comment 2

[Laura Mesa [:lmesa] [:lvmesa]]

Just an FYI--this is blocking a mobile demo for Fx 4 Mobile release, runfield. 

CC-ing clooney and thomas.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 510575 [details] [diff] [review]
Patch

nit: } else {

I'm wondering if this is the best place to put the code. I guess it's OK for now.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #3)
> Comment on attachment 510575 [details] [diff] [review]
> Patch
> 
> nit: } else {
> 
> I'm wondering if this is the best place to put the code. I guess it's OK for
> now.

What do you mean? Do you want to move it inside the tapUp method or what?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 510575 [details] [diff] [review]
> > Patch
> > 
> > nit: } else {
> > 
> > I'm wondering if this is the best place to put the code. I guess it's OK for
> > now.
> 
> What do you mean? Do you want to move it inside the tapUp method or what?

Not sure. It just seems a bit out of place here. Feel free to land this. I can think more about it and file a new bug later, if needed.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This should be efficient in tomorrow's nightly.

http://hg.mozilla.org/mobile-browser/rev/fc4b66851459

Comment 7

[Aakash Desai [:aakashd]]

Where is the location of the mobile demo? I'd like to verify this bug.

Comment 8

[Matt Brubeck (:mbrubeck)]

Backed out because of bug 633539:
http://hg.mozilla.org/mobile-browser/rev/eaf417128996

Comment 9

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Simple change to pass along whether the tapUp is a click or a pan.

Comment 10

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/76bd4e6c558f

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 511766 [details] [diff] [review]
patch

We could look at using UIEvents and event.detail for passing this kind of data too.

Comment 12

[Tony Chung [:tchung]]

(In reply to comment #7)
> Where is the location of the mobile demo? I'd like to verify this bug.

asking for this again, thanks.

Comment 13

[Paul Rouget [:paul]]

Tony: http://people.mozilla.com/~prouget/demosfx4/runfield.mobile/demo.html
(password sent by email)

Comment 14

[Tony Chung [:tchung]]

Thanks Paul.   I've compared the demo on the 20110316 build versus 20110209 build, and the older build seems much more noticably delayed onClick.  However, the newer build still seems to exhibit a shorter delay, and not as snappy as desktop builds.

Paul ,can you give it a try and see if this fixes your original problem?   in my mind, its much better, but not 100% responsive as i would have expected.

Comment 15

[Paul Rouget [:paul]]

It's much much much better. Perfect.
I don't see how it could be more responsive.

Comment 16

[Martijn Wargers (dead)]

Marking verified fixed then, based on comment 15.