630604 - search addons field too narrow to display the placeholder text for most locales

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: screenshot of the problem

Mozilla/5.0 (X11; Linux i686; rv:2.0b11pre) Gecko/20110131 Firefox/4.0b11pre

(see attached screenshot)

The <textbox> element is not wide enough for the placeholder text it contains for most of our locales therefore the text is cut out, which is a problem since it indicates what the search box is about.

We have a lot of space on the left so increasing it should not be a problem.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Would it make sense to specify the width by an entity, so each locale can set the width depending on their needs? Or do we want to increase the width for all locales?

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

I would be in favor of widening the text field since we have lots of unused space, this way we fix it for all locales at the same time.

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

this is for all platforms

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Pascal, do you know which language has the longest placeholder string?

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

I don't know but I think filip has a tool to extract that data as part of his glossaire tool, I'll ask him tonight of he can tell me when he gets back from work.

Comment 6

[Axel Hecht [:Pike]]

Tamil looks promising, according to http://mxr.mozilla.org/l10n-central/search?string=search.placeholder&find=toolkit/.*/extension

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I don't have all those fonts installed. So what's the language code of tamil?

Comment 8

[Axel Hecht [:Pike]]

Tamil is 'ta'. I don't have all fonts either, that's the one I could see glyphs for. Font help's at http://ta.wikipedia.org/wiki/%E0%AE%B5%E0%AE%BF%E0%AE%95%E0%AF%8D%E0%AE%95%E0%AE%BF%E0%AE%AA%E0%AF%8D%E0%AE%AA%E0%AF%80%E0%AE%9F%E0%AE%BF%E0%AE%AF%E0%AE%BE:Font_help.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: patch fixing the issue for all locales

Here is a patch that would fix the issue for all locales (bn-IN had the longest placeholder string so I used that one for testing)

Asking a review to Dave Townsend who seems to regularly patch this file.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: screenshot with the patch

This is how the addons manager looks with the patch, I actually think it looks better even in English with a longer search field :)

Comment 11

[Dave Townsend [:mossop]]

Comment on attachment 511186 [details] [diff] [review]
patch fixing the issue for all locales

Needs UI-review first

Comment 12

[Jennifer Morrow [:Boriss] (UX)]

(In reply to comment #11)
> Comment on attachment 511186 [details] [diff] [review]
> patch fixing the issue for all locales
> 
> Needs UI-review first

Looks good.  An ever better fix would mirror the size of the user's search bar on load, but this is sufficient for now.

Comment 13

[Dave Townsend [:mossop]]

Comment on attachment 511186 [details] [diff] [review]
patch fixing the issue for all locales

Approved to land

Comment 14

[Pascal Chevrel:pascalc (PTO until April 26)]

thanks, adding checkin-needed keyword which I think is the next step in the process, right?

Comment 15

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Correct!

Comment 16

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/96dddc42612a

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110222 Firefox/4.0b12pre