630639 - Annotate crashes with phase (startup, shutdown) of browser

Status: RESOLVED WORKSFORME

(Core :: General, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Sounds like this would be helpful.

Comment 1

[Josh Matthews [:jdm]]

Doesn't that stack usually show ~ScopedXPCOM or something similarly revealing if shutdown is in progress?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #1)
> Doesn't that stack usually show ~ScopedXPCOM or something similarly revealing
> if shutdown is in progress?

No idea. Got some examples?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Annotate shutdown during "Quit"

Here's a possible patch

Comment 4

[Josh Matthews [:jdm]]

See the stacks in bug 612537 and bug 612546.  Granted, this only works for crashes that occur during XPCOM shutdown, not just after shutdown has been initiated from nsIAppStartup::Quit.

Comment 5

[Justin Dolske [:Dolske]]

Over in bug 723802 we were just talking about how to better-correlate the telemetry probes there with the new startup crash detection. Figure it would also be interesting to know if a crash happened when the user was in the process of quitting the browser.

The 4 basic phases would be:

  EarlyStartup (before startup-crash detection begins)
  Startup
  Normal (after startup-crash detection ends)
  Shutdown

Comment 6

[Robert Kaiser]

I just looked into bug 723802 and wonder why the hell we are doing this in telemetry and not actually annotating this in some way on the crash report itself? I sometimes get the feeling that telemetry is re-inventing things we already have a system for elsewhere. :(

Comment 9

[David Lawrence [:dkl]]

Changing qe-verify? to qe-verify+.

Comment 10

[Jens Stutte [:jstutte]]

There is a landed patch and a qe-verify+ such that I assume there is not much to do. If we still think we need more annotations, please file new bugs, though I think we have much more shutdown annotations these days at least, less sure about startup.