Remove support for building without MOZ_CRASHREPORTER

RESOLVED WONTFIX

Status

()

Toolkit
Crash Reporting
RESOLVED WONTFIX
7 years ago
7 years ago

People

(Reporter: jrmuizel, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
Are there any compelling reasons for keeping around the ability to build without crashreporter? It would be nice to rip out a bunch #ifdef MOZ_CRASHREPORTER.

Comment 1

7 years ago
Most Linux distros disable the crash reporter for their builds.
(Reporter)

Comment 2

7 years ago
(In reply to comment #1)
> Most Linux distros disable the crash reporter for their builds.

The code or just the feature? Do you know why they disable crash reporter?

Comment 3

7 years ago
Part of it is that we don't have symbols for their builds. I suspect there are also distros that see the crash reporter as a privacy issue.
(Reporter)

Comment 4

7 years ago
(In reply to comment #3)
> Part of it is that we don't have symbols for their builds. I suspect there are
> also distros that see the crash reporter as a privacy issue.

Even without MOZ_CRASHREPORTER, crash reporter can still be disable at runtime.
(In reply to comment #1)
> Most Linux distros disable the crash reporter for their builds.

This is no longer true, Fedora, Ubuntu and OpenSuSE are all uploading symbols to our symbol server.

That being said, the most compelling reason for MOZ_CRASHREPORTER is that it only supports a very specific set of platforms, and for most people doing ports, it's not a high priority, so you'd be raising the bar for a port with very little gain for the person doing the work.
(Reporter)

Comment 6

7 years ago
(In reply to comment #5)
> That being said, the most compelling reason for MOZ_CRASHREPORTER is that it
> only supports a very specific set of platforms, and for most people doing
> ports, it's not a high priority, so you'd be raising the bar for a port with
> very little gain for the person doing the work.

That makes sense to me.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
I doubt it's worth the work, but another option would be to always build the platform-agnostic parts and/or perform the various runtime annotations.
(Reporter)

Comment 8

7 years ago
(In reply to comment #7)
> I doubt it's worth the work, but another option would be to always build the
> platform-agnostic parts and/or perform the various runtime annotations.

This is my plan if I decide that it matters enough.
I would support that, it wouldn't be much work to change MOZ_CRASHREPORTER to mean "has a working Breakpad implementation", and always build the code that supplies the crashreporter APIs (like AnnotateCrashReport).
You need to log in before you can comment on or make changes to this bug.