630690 - Flash crash [@ gfxASurface::GetType() ] getting surface type

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Jim Mathies [:jimm]]

0 	xul.dll 	gfxASurface::GetType 	gfx/thebes/gfxASurface.cpp:233
1 	xul.dll 	mozilla::gfx::SharedDIBSurface::IsSharedDIBSurface 	gfx/ipc/SharedDIBSurface.cpp:93
2 	xul.dll 	mozilla::plugins::PluginInstanceChild::ReadbackDifferenceRect 	dom/plugins/PluginInstanceChild.cpp:2886
3 	xul.dll 	mozilla::plugins::PluginInstanceChild::ShowPluginFrame 	dom/plugins/PluginInstanceChild.cpp:2812
4 	xul.dll 	mozilla::plugins::PluginInstanceChild::InvalidateRectDelayed 	dom/plugins/PluginInstanceChild.cpp:2924
5 	xul.dll 	MessageLoop::RunTask 	ipc/chromium/src/base/message_loop.cc:343
6 	xul.dll 	MessageLoop::DeferOrRunPendingTask 	ipc/chromium/src/base/message_loop.cc:351
7 	xul.dll 	MessageLoop::DoWork 	ipc/chromium/src/base/message_loop.cc:451
8 	xul.dll 	base::MessagePumpForUI::DoRunLoop 	ipc/chromium/src/base/message_pump_win.cc:213
9 	xul.dll 	base::MessagePumpWin::RunWithDispatcher 	ipc/chromium/src/base/message_pump_win.cc:52
10 	xul.dll 	base::MessagePumpWin::Run 	ipc/chromium/src/base/message_pump_win.h:78
11 	xul.dll 	MessageLoop::RunInternal 	ipc/chromium/src/base/message_loop.cc:219


#9 top crasher in beta 10. Checking for a valid shared DIB surface. Appears unrelated to anything flash is doing.

Comment 1

[Benjamin Smedberg]

I'll bet that mBackSurface is null here. I can't guess why, yet. http://hg.mozilla.org/mozilla-central/annotate/FIREFOX_4_0b10_RELEASE/dom/plugins/PluginInstanceChild.cpp#l2886

Comment 2

[Jim Mathies [:jimm]]

This could probably block on bug 626602 since this code is about to get another overhaul.

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

626602 landed, what's the prognosis for a fix here?

Comment 4

[Benjamin Smedberg]

We need to check crash-stats for next-beta, I believe that bug 626602 will just make this go away.

Comment 5

[Jim Mathies [:jimm]]

Not a single crash that matches this in the 20110216030352 build. Looks fixed to me.

Comment 6

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

concur!