630732 - Talos remote does not respect logFile and fails

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[cmtalbert]

1. Run talos remotePerfConfigurator with the command line:
python remotePerfConfigurator.py -v -e org.mozilla.fennec --remoteDevice 10.250.5.102 --activeTests tp4 --sampleConfig remote.config --output tegratp4-noc-test.config --noChrome --webServer 10.250.5.14 --logFile foo.log

2. Check out your tegratp4-noc-test.config file.  You'll note that the talos.logFile setting in the preference is "browser_output.txt".  It ought to be foo.log.

3. Run test: python run_tests.py tegratp4-noc-test.config

= Expected =
Things would work and you'd get your output back in foo.log.  

= Actual =
Instead you do get a foo.log created, and inside it you get an error.  The error comes about because Talos goes looking for the browser output on the device and is looking for /sdcard/tests/foo.log.  It won't find foo.log on the device, because it wasn't created due to the talos.logFile setting in the config file.  You will note that /sdcard/tests/browser_output.txt does exist.

Comment 1

[cmtalbert]

Attachment: Ok, this works

Ok, I found an easy way to do this.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 508964 [details] [diff] [review]
Ok, this works

in testing this it seems to work well.  I recall this being a tricky thing to solve when I first did this remotely.  One of the quirks is having browser_log (for getInfo) and talos.logFile (for the extensions) be synchronized.  In this case, we are synchronized and all is well, but it is something too look out for.

Comment 3

[cmtalbert]

(In reply to comment #2)
> Comment on attachment 508964 [details] [diff] [review]
> Ok, this works
> 
> in testing this it seems to work well.  I recall this being a tricky thing to
> solve when I first did this remotely.  One of the quirks is having browser_log
> (for getInfo) and talos.logFile (for the extensions) be synchronized.  In this
> case, we are synchronized and all is well, but it is something too look out
> for.
Um, ok, does this mean we can check this in?  Or are we waiting for something?  I don't have commit access to talos (I think) so I'll need you to do this?  (The tables have turned bwahahaha).

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/build/talos/pushloghtml?changeset=4ef9398126db

Comment 5

[alice nodelman [:alice] [:anode]]

Has this been pushed to production?

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

I am not sure, I can't find reference to a talos downtime in related bugs after Feb 3rd.

Comment 7

[alice nodelman [:alice] [:anode]]

Okay, should it be in production? :)

Comment 8

[alice nodelman [:alice] [:anode]]

Also, if we have landed the patch should this bug be closed?

Comment 9

[Jeff Hammel]

Yes :)