Closed Bug 630746 Opened 9 years ago Closed 9 years ago

Add a flag to jstests.py to skip extension tests

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: Waldo, Assigned: Waldo)

Details

(Whiteboard: [fixed-in-tracemonkey])

Attachments

(1 file)

Attached patch PatchSplinter Review
...to make it easier for other engines to run only the tests that they *should* pass.  I realized we needed this when, a bit ago, I was responding to email involving other non-SpiderMonkey JS hackers explaining how to run our test suite and realized it wasn't really possible to do it non-noisily, not easily at least.
Attachment #508977 - Flags: review?
Attachment #508977 - Flags: review? → review?(dmandelin)
Comment on attachment 508977 [details] [diff] [review]
Patch


>+def exclude_extension_tests(test_list):
>+    r = re.compile(r'^.*?/extensions/')
>+    return [_ for _ in test_list if r.match(_.path) is None]
>+

This can be just 

  def exclude_extension_tests(test_list):
      return [_ for _ in test_list if '/extensions/' not in _.path]

r+ with that (make sure I got it right).
Attachment #508977 - Flags: review?(dmandelin) → review+
Actually, the extra method's kind of superfluous, just folded it into the location that would have called it -- pushed with those changes:

http://hg.mozilla.org/tracemonkey/rev/73efdea6fda0
Whiteboard: [fixed-in-tracemonkey]
I wonder would a better way to accomplish this have been to extend the [TEST-SPECS] syntax to allow a ! at the front. So the command would be:

 tests/jstests.py objdir/js !extensions
http://hg.mozilla.org/mozilla-central/rev/73efdea6fda0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.