STR: 1.Login to https://addons.allizom.org/en-US/developers 2.Go to Edit Add-ons Listing page of any add-on 3.Goto Status & Versions page by clicking on Manage Status and Versions link in Left hand side 4.Click "Upload New Version" and click "select a file" and select any add-on file 5.After the upload process starts click Cancel 6.Now again click "Upload New Version" Expected Result: at step 5 after clicking the Cancel, the add-on upload process should be canceled Actual Result: at step 5, even after clicking cancel the upload still continuous which you can see at step 6
https://github.com/jbalogh/zamboni/commit/1506f0210aedbac0749ba2863316fa3683e9afa1 The fix is somewhere in there.
I can actually still reproduce this: http://screencast.com/t/9NmVpImHR
Good catch. I changed the event name one place, but not the other. http://github.com/jbalogh/zamboni/commit/5ae1ddb
The feedback isn't immediate (besides the Cancel link disappearing), and the add-on appears to keep uploading, actually (since it continues with its progress meter, and eventually gets to the validator, which appears to propagate the failure reason. Either here or in a new bug (your choice), I'd like to see it stop all activity, or at least give more immediate feedback to the user (and cancel progress indicators, etc.) http://screencast.com/t/8bQJwzuO5h is a screencast of current behavior.
I was going to do this separately (for all errors), but since you mentioned it, here we go: http://github.com/jbalogh/zamboni/commit/1d300c7
STR: 1. Load the /versions page for an add-on 2. Upload a new version (pick an add-on which takes a while to validate (easier to spot the bug) 3. While the add-on is being validated, click 'cancel' 4. Click on 'upload a new version' again. observed behavior: upload continue even after the cancellation. reopening...
I fixed the wrong bug. There are two cancel buttons on this page, and I thought it was referring to the small one right under the progress bar. So, I found a bug by misinterpreting the original one :)
Let's get this in for freeze today