630838 - Clear document.popupNode between b-c tests

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

A browser-chrome test can set document.popupNode to a custom value, to check a context menu functionality, or a command, or whatever.

Unfortunately it's hard to ensure that all tests will then cleanup it correctly on shutdown, indeed I can find at least 6 b-c tests not doing it, plus in case of failure/timeout there is risk the cleanup doesn't run (actually they should instead use registerCleanupFunction...).

Not clearing it is problematic, since some next text could really test a popup opening and expect document.popupNode to be meaningful.

Since it's easy to handle this at the harness level I think we can do it as an additional protection against oranges.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

some blaming: http://mxr.mozilla.org/mozilla-central/search?string=document.popupNode&find=browser_

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

on try: http://tbpl.mozilla.org/?tree=MozillaTry&rev=bf8b20c1e851

Comment 4

[Asaf Romano (gone)]

Comment on attachment 509078 [details] [diff] [review]
patch v1.0

r=mano. I'm not sure what's the policy for testing/, so keeping the request for gavin. If you know it's enough though, go ahead and land it.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 509078 [details] [diff] [review]
patch v1.0

Can you put it before the setDuration block? Doesn't make much difference but it's easier conceptually to put all the "cleanup" together.

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

yes, I will do. I did not put it there because it's not part of the test-defined-code... but as you said won't make much difference.

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.1

Addressed Gavin's comment.

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/dc93a523cdbd