updateKey and updateURL in install.rdf need to be validation errors

VERIFIED FIXED in 5.12.9

Status

P1
major
VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: jorgev, Assigned: basta)

Tracking

unspecified
5.12.9

Details

(Whiteboard: [ReviewTeam], URL)

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
This is one of the few cases where we require the validator to show an error and don't allow the upload to continue.
Please make both of these flags throw errors.
(Assignee)

Comment 1

8 years ago
Can do; should we also be banning the use of updateLink?
(Reporter)

Comment 2

8 years ago
Never heard of it. Where did you see it?
I think updateLink would only appear in update.rdf, not install.rdf
(Assignee)

Comment 4

8 years ago
Even better. Done:

https://github.com/mattbasta/amo-validator/commit/b1b729c931032c953c493badb6e9769582330281
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 5

8 years ago
Created attachment 509577 [details]
post-fix screenshot

validation error when install.rdf includes UpdateURL:
https://addons.allizom.org/en-US/developers/upload/c6b6ead4f74446cda7bcb8de0ebe3d46

validation error when install.rdf includes Updatekey:
https://addons-next.allizom.org/en-US/developers/upload/3333f949bf5941c6891e6a55bd898652

Comment 6

8 years ago
Created attachment 509578 [details]
post-fix screenshot

Updated

8 years ago
Status: RESOLVED → VERIFIED
(Reporter)

Comment 7

7 years ago
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.