630897 - Reflect.parse: catch clauses should always be in an array

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Dave Herman [:dherman]]

The Reflect.parse API special-cases the 0 and 1 cases of catch clauses, for compatibility with standard ECMAScript, which doesn't currently allow multiple clauses. But since catch guards seem pretty harmonious, we should just bite the bullet and simplify the type. This will be more convenient for clients, who don't have to insert delicate special-case logic (especially since testing array-ness is so fraught).

I'll have to check with the a.m.o folks who are using Reflect.parse() to make sure this API change is OK with them.

Dave

Comment 1

[Matt Basta [:basta]]

We're fine with a change, just let us know when you do it and what nodes you're changing the interfaces for. :)

Comment 2

[Dave Herman [:dherman]]

Attachment: catch clauses are always in an array

Comment 3

[Dave Herman [:dherman]]

http://hg.mozilla.org/tracemonkey/rev/5b5cdbaaccd5

Comment 4

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/5b5cdbaaccd5

Comment 5

[Dave Herman [:dherman]]

Attachment: final version that landed in TM; to cherrypick for aurora

Comment 6

[Dave Herman [:dherman]]

Comment on attachment 544138 [details] [diff] [review]
final version that landed in TM; to cherrypick for aurora

This landed in tracemonkey last week, but cdleary's merge to m-c today landed after the merge from m-c to aurora:

http://groups.google.com/group/mozilla.dev.tech.js-engine.internals/browse_thread/thread/626c85124555c0c9

Dave

Comment 7

[Dave Herman [:dherman]]

Comment on attachment 544138 [details] [diff] [review]
final version that landed in TM; to cherrypick for aurora

Merged into Aurora:

http://hg.mozilla.org/releases/mozilla-aurora/rev/75552dfd25c2

Dave