Checkerboard after orientation change

VERIFIED FIXED

Status

defect
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

9 years ago
Sometimes checkerboards appear after you change orientation. If the page is scaled out to show it entirely, the orientation change can fire a scale change as well, which updates the viewport:

http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.js#2723

Otherwise, we need to ensure that _updateCacheViewport is called.
Assignee

Comment 1

9 years ago
Posted patch Patch v1 (obsolete) — Splinter Review
There doesn't seem to be any pretty way to do this. scale changes will do it, but only if there is an actual change. I could use:

if(browser.active) browser.active = true

This seemed just as good at that point.
Attachment #509169 - Flags: review?(ben)
Comment on attachment 509169 [details] [diff] [review]
Patch v1

Hm, is there any reason this isn't in the resize event handler? When I look at updateDefaultZoomLevel, I don't see why it demands a cache update. A resize on the other hand would need it because the dimensions of the browser have changed.
Attachment #509169 - Flags: review?(ben)
Assignee

Comment 3

9 years ago
Posted patch Patch v2 (obsolete) — Splinter Review
Fires update after resize. I think I would rather find a place that minimizes calls to update the cache viewport. With this patch it will happen twice in some cases.
Attachment #509169 - Attachment is obsolete: true
Attachment #509254 - Flags: review?(ben)
Assignee

Comment 4

9 years ago
Comment on attachment 509254 [details] [diff] [review]
Patch v2

Oops. Wrong version... just a sec.
Attachment #509254 - Flags: review?(ben)
Assignee

Comment 5

9 years ago
Posted patch Patch v2.1Splinter Review
Attachment #509254 - Attachment is obsolete: true
Attachment #509261 - Flags: review?(ben)
Comment on attachment 509261 [details] [diff] [review]
Patch v2.1

I'm not worried much about multiple displayport calls to the same area.
Attachment #509261 - Flags: review?(ben) → review+
Assignee

Comment 7

9 years ago
Pushed:
http://hg.mozilla.org/mobile-browser/rev/ecb835121837
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified FIXED on builds:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b12pre) Gecko/20110211 Firefox/4.0b12pre Fennec/4.0b5pre
Status: RESOLVED → VERIFIED
bugspam
Assignee: nobody → wjohnston
You need to log in before you can comment on or make changes to this bug.