Closed Bug 630942 Opened 10 years ago Closed 10 years ago
Checkerboard after orientation change
Sometimes checkerboards appear after you change orientation. If the page is scaled out to show it entirely, the orientation change can fire a scale change as well, which updates the viewport: http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.js#2723 Otherwise, we need to ensure that _updateCacheViewport is called.
There doesn't seem to be any pretty way to do this. scale changes will do it, but only if there is an actual change. I could use: if(browser.active) browser.active = true This seemed just as good at that point.
Comment on attachment 509169 [details] [diff] [review] Patch v1 Hm, is there any reason this isn't in the resize event handler? When I look at updateDefaultZoomLevel, I don't see why it demands a cache update. A resize on the other hand would need it because the dimensions of the browser have changed.
Fires update after resize. I think I would rather find a place that minimizes calls to update the cache viewport. With this patch it will happen twice in some cases.
Comment on attachment 509254 [details] [diff] [review] Patch v2 Oops. Wrong version... just a sec.
Comment on attachment 509261 [details] [diff] [review] Patch v2.1 I'm not worried much about multiple displayport calls to the same area.
Attachment #509261 - Flags: review?(ben) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
verified FIXED on builds: Mozilla/5.0 (Android; Linux armv71; rv:2.0b12pre) Gecko/20110211 Firefox/4.0b12pre Fennec/4.0b5pre
Status: RESOLVED → VERIFIED
Assignee: nobody → wjohnston
You need to log in before you can comment on or make changes to this bug.