Closed Bug 631001 Opened 9 years ago Closed 9 years ago
Password sync: consider batching in transactions to avoid fsyncs
Same as bug 630720, but for passwords to make us not suck on Fennec, until we get async batch APIs. Needs bug 630730 first.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
No need for a full blown server setup to test the password store. Also, engine.sync() doesn't throw anymore anyway, so the test wasn't really testing that bit anymore.
Attachment #509650 - Flags: review?(mconnor)
Same thing as with forms, but a bit more complicated because we don't always have the DB connection. Also, this needs bug 631403.
Attachment #509652 - Flags: review?(mconnor)
OS: Windows 7 → All
Hardware: x86 → All
Whiteboard: [has patch][needs review mconnor]
Try build coming up: http://tbpl.mozilla.org/?tree=MozillaTry&rev=2ddda5ac4817
Comment on attachment 509652 [details] [diff] [review] Part 2: Batch-apply password records in transaction After we merge to m-c, we should run before/after full syncs again.
Attachment #509652 - Flags: review?(mconnor) → review+
Whiteboard: [has patch][needs review mconnor] → [has patch][has review]
Pushed to fx-sync: Part 1: https://hg.mozilla.org/services/fx-sync/rev/2db63a4337b2 Part 2: https://hg.mozilla.org/services/fx-sync/rev/25b9314ebb97 Will resolve once we land on m-c (will land in places first).
Whiteboard: [has patch][has review] → [has patch][has review][fixed in fx-sync]
Merged to places: Part 1: http://hg.mozilla.org/projects/places/rev/80960bc75d83 Part 2: http://hg.mozilla.org/projects/places/rev/8d179f565e1b
Whiteboard: [has patch][has review][fixed in fx-sync] → [fixed in fx-sync][fixed in places]
Landed: Part 1: http://hg.mozilla.org/mozilla-central/rev/80960bc75d83 Part 2: http://hg.mozilla.org/mozilla-central/rev/8d179f565e1b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-sync][fixed in places]
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.