631001 - Password sync: consider batching in transactions to avoid fsyncs

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

Same as bug 630720, but for passwords to make us not suck on Fennec, until we get async batch APIs. Needs bug 630730 first.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: Part 1: Make password store tests more unit-y

No need for a full blown server setup to test the password store. Also, engine.sync() doesn't throw anymore anyway, so the test wasn't really testing that bit anymore.

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: Part 2: Batch-apply password records in transaction

Same thing as with forms, but a bit more complicated because we don't always have the DB connection. Also, this needs bug 631403.

Comment 3

[Philipp von Weitershausen [:philikon]]

Try build coming up: http://tbpl.mozilla.org/?tree=MozillaTry&rev=2ddda5ac4817

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 509652 [details] [diff] [review]
Part 2: Batch-apply password records in transaction

After we merge to m-c, we should run before/after full syncs again.

Comment 5

[Philipp von Weitershausen [:philikon]]

Pushed to fx-sync:

Part 1: https://hg.mozilla.org/services/fx-sync/rev/2db63a4337b2
Part 2: https://hg.mozilla.org/services/fx-sync/rev/25b9314ebb97

Will resolve once we land on m-c (will land in places first).

Comment 6

[Philipp von Weitershausen [:philikon]]

Merged to places:

Part 1: http://hg.mozilla.org/projects/places/rev/80960bc75d83
Part 2: http://hg.mozilla.org/projects/places/rev/8d179f565e1b

Comment 7

[Philipp von Weitershausen [:philikon]]

Landed:

Part 1: http://hg.mozilla.org/mozilla-central/rev/80960bc75d83
Part 2: http://hg.mozilla.org/mozilla-central/rev/8d179f565e1b