631038 - mobile-optimized pages is half-sized when reloading in portrait mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Attachment: bug screenshot

Steps to Reproduce:
1. Change your user agent to Mozilla/5.0 (macintosh; U; Intel Mac OS X 10.5; en-US rv:1.9.2.5) Gecko/20100614 Firefox/3.6.5pre Fennec/1.1
2. Go to input.stage.mozilla.com/feedback while in portrait mode (if you're using a desktop build, re-size the browser window to look like portrait mode)

Actual Results:
The page is half the size of the viewable area

Expected Results:
The page fits the entire size of the viewable area.

Comment 1

[Aakash Desai [:aakashd]]

Attachment: new bug screenshot!

Now its half horizontally

Comment 2

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

I don't have a way to duplicate this problem.  Fred is taking a look at this on his Android phone at the moment.

Comment 3

[Fred Wenzel [:wenzel]]

I can't reproduce the half-size problem: On my Nexus S, the page shows up with the correct width. Only after submitting, I end up on the thank-you page but not at the top of the screen (I end up being half-way scrolled down like I was before clicking submit).

Further, the language picker ends up somehow next to the title bar somehow. I'll add that to bug 631673.

Comment 4

[Matt Brubeck (:mbrubeck)]

This looks like a Fennec bug.  I've seen this intermittently on a variety of pages, not just the mobile input page.

Comment 5

[Matt Brubeck (:mbrubeck)]

I found steps to reproduce:
1. Open a page with width=device-width, e.g. http://people.mozilla.com/~mbrubeck/test/hello.html
2. Press reload.

Comment 6

[Matt Brubeck (:mbrubeck)]

Reloading causes a "pagehide" event, and browser.onPageHide() sets the scale to 1, causing this effect.

Comment 7

[Matt Brubeck (:mbrubeck)]

Attachment: patch

I think we can just remove this code - there's no great reason to set scale to 1.0 here - especially since 1.0 is below the minimum zoom level on many pages, and causes the views shown in the attached screenshots.

This code was moved to the "pagehide" listener in bug 598111.  Before that, we set scale=1 on location change.  Neither of these should be necessary in the binding, since the front-end (browser.js) resets the zoom level on navigation anyway.

Comment 8

[Benjamin Stover (:stechz)]

Comment on attachment 511831 [details] [diff] [review]
patch

Hm. I'd prefer if we did this the other way: no more resetting zoom in browser.js and make resetting zoom level part of the browser binding; it seems like something the browser should take care of. However, all the meta viewport code is in browser.js, so this makes sense to me.

Comment 9

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/c0f28968a38e

We should definitely move all meta-viewport and zoom limit handling into the browser binding in toolkit long-term, so that future Mozilla apps can use it too.

Comment 10

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b13pre) Gecko/20110317 Firefox/4.0b13pre Fennec/4.0b6pre