631085 - insertbefore="browser" doesn't insert hbox at the top, it inserts it at the bottom instead

Status: RESOLVED INVALID

(Firefox :: Extension Compatibility, defect)

Description

[Andrei]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b10) Gecko/20100101 Firefox/4.0b10
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b10) Gecko/20100101 Firefox/4.0b10

The following part of xul:
<hbox insertbefore="browser" style="border-top:1px solid #c8c8c8;">
<browser id="my_search_browser" type="content-targetable" />
</hbox>
in Firefox 4 shows hbox at the bottom of browser window.

Reproducible: Always

Steps to Reproduce:
1. Install extension
2. Go to Tools->WaveMetrix Analyst Search->Show Logging Pane
Actual Results:  
Hbox is shown at the bottom of browser window.

Expected Results:  
Hbox is shown at the top of browser window.

Comment 1

[Andrei]

Attachment: Add-on which causes bug

Comment 2

[Andrei]

Attachment: Difference in showing content in Firefox 3 and Firefox 4

In the attachment you can find the right content showing in Firefox 3 and how it is showed in Firefox 4 (box at the bottom of the window instead of top). I tried the following ways:
1) Inserting before "broswer" in XUL, inserting before/after one of the other elements of the deck, like insertbefore="browser-border-start", insertafter="navigation-toolbox", etc.
2) Using javascript to modify the XUL dynamically: get necessary element and trying to appendChild(...) or insertBefore(...).
3) Other approaches.
None of them gives correct layout in Firefox 4.

Comment 3

[Andrei]

Attachment: Extension which causes issue

Extension which shows panel at startup with problem description: 'This panel is the problem, it should be at the top'.

Comment 4

[Andrei]

Attachment: Extension which causes issue

Shows panel on startup which contains problem description: `This panel is the problem, it should be at the top`.

Comment 5

[Kris Maglione [:kmag]]

This is invalid. The insertbefore attribute does not specify an attribute which is a child of the #main-window element it overlays.

Comment 6

[Andrei]

(In reply to comment #5)
> This is invalid. The insertbefore attribute does not specify an attribute which
> is a child of the #main-window element it overlays.

Thank you for your reply. But could you explain what do you mean? This code is working well in Firefox 3 and it is taken from mozilla documentation (for example, you can find similar thing here: https://developer.mozilla.org/en/updating_extensions_for_firefox_3). Also, as I wrote, the problem is still there if we insert some element also dynamically (https://developer.mozilla.org/en/dynamically_modifying_xul-based_user_interface). This extension is working as expected and in correct way for Firefox 3, code is right, but in Firefox 4 it is shown at the bottom, not at the top.

Comment 7

[Andy McKay]

Legacy extensions are no longer valid in Firefox 57, closing.