631096 - "-- all --" in versions list is not clickable

Status: VERIFIED FIXED

(Input :: General, defect)

Description

[Fred Wenzel [:wenzel]]

The versions filter is a dropdown list that used to have the current version "selected" (i.e., the applicable <option> tag had a selected attribute). This is missing now, which results in the first item being selected by default. Therefore, no change event fires when you actually do click on the first item.

Need to re-add code that marks the right item as selected in the template.

Guess a little test with PyQuery is also in order.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This is causing a failure in the Selenium tests.

Comment 2

[Fred Wenzel [:wenzel]]

Since this is a pretty obvious regression, I'll pick this up.

Comment 3

[Fred Wenzel [:wenzel]]

I readded the code that used to set the attribute correctly and added a test to make sure it stays so in the future.

http://github.com/fwenzel/reporter/commit/99fadd5

Comment 4

[Rebecca Billings [:rbillings]]

Verified able to click 'all' option, data displays

Comment 5

[Rebecca Billings [:rbillings]]

please re-open if this fix does not correct the automation tests

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I can confirm that this is no longer causing an automated test failure.