Add new API/SWF versions for SWF13

VERIFIED FIXED

Status

defect
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: stejohns, Unassigned)

Tracking

Details

Attachments

(3 attachments)

Posted patch PatchSplinter Review
Rubber-stamping myself
Attachment #509313 - Flags: review+
TR 5875:ec74cd1cba8a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
(In reply to comment #1)
> TR 5875:ec74cd1cba8a

This change is causing a versioned testcase to fail, bug #456852
as3/RuntimeErrors/Error1115NotAConstructor.as
Blocks: 456852
Should the shell now be running as AVMFEATURE_SWF13?

diff --git a/shell/avmshell-features.h b/shell/avmshell-features.h
--- a/shell/avmshell-features.h
+++ b/shell/avmshell-features.h
@@ -225,21 +225,21 @@
   #define AVMFEATURE_BUFFER_GUARD 0
 #endif
 
 #ifndef AVMFEATURE_VALGRIND
   #define AVMFEATURE_VALGRIND 0
 #endif
 
 #ifndef AVMFEATURE_SWF12
-  #define AVMFEATURE_SWF12 1
+  #define AVMFEATURE_SWF12 0
 #endif
 
 #ifndef AVMFEATURE_SWF13
-  #define AVMFEATURE_SWF13 0
+  #define AVMFEATURE_SWF13 1
 #endif
 
 #ifndef AVMFEATURE_SWF14
   #define AVMFEATURE_SWF14 0
 #endif
 
 #ifndef AVMFEATURE_SWF15
   #define AVMFEATURE_SWF15 0
Attachment #509417 - Flags: review?(stejohns)
Attachment #509418 - Flags: review?(stejohns)
changeset: 5881:09dc3e5508d2
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 500476: verified fix and re-enabling testcase (r+brbaker)bug 631101: add a failing testcase into the smokes list so it gets caught quickly (r+brbaker)

http://hg.mozilla.org/tamarin-redux/rev/09dc3e5508d2
Attachment #509417 - Flags: review?(stejohns) → review+
Comment on attachment 509418 [details] [diff] [review]
default shell to be swf13 compatible

My bad on both of these -- I rushed to push something out.
Attachment #509418 - Flags: review?(stejohns) → review+
changeset: 5883:6fd339d2a5db
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 631101: add new SWF13 support, a couple of locations where missed in previous changeset (r+stejohns)

http://hg.mozilla.org/tamarin-redux/rev/6fd339d2a5db
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.