631119 - Dummy popup widgets created in content process can interrupt IME state

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

For all puppet widgets, we get here

http://mxr.mozilla.org/mozilla-central/source/widget/src/xpwidgets/PuppetWidget.cpp#114

but we should definitely shouldn't reset IME state if aInitData->mWindowType == eWindowType_popup.  Once bug 610670 lands we'll be able to move that code out of PuppetWidget, but until then if we get near a release that might be worth band-aiding.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Don't let fake popup widgets interfere with IME state

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 513217 [details] [diff] [review]
Don't let fake popup widgets interfere with IME state

Safe patch that can fix weird IME bugs on pages with <select>s.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Chris, can you write a test to make sure we don't regress this?

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://hg.mozilla.org/mozilla-central/rev/fb28cc7c6bb0

Comment 5

[Martijn Wargers (dead)]

Comment 0 mentions:
"Once bug 610670 lands we'll be able to move that code out of PuppetWidget, but until then if we get near a release that might be worth band-aiding."

Bug 610670 is fixed now, so I guess that code can be moved out of PuppetWidget now?