Closed Bug 631119 Opened 14 years ago Closed 14 years ago

Dummy popup widgets created in content process can interrupt IME state

Categories

(Core :: Widget, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: cjones, Assigned: cjones)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

For all puppet widgets, we get here

http://mxr.mozilla.org/mozilla-central/source/widget/src/xpwidgets/PuppetWidget.cpp#114

but we should definitely shouldn't reset IME state if aInitData->mWindowType == eWindowType_popup.  Once bug 610670 lands we'll be able to move that code out of PuppetWidget, but until then if we get near a release that might be worth band-aiding.
Assignee: nobody → jones.chris.g
Attachment #513217 - Flags: review?(roc)
Comment on attachment 513217 [details] [diff] [review]
Don't let fake popup widgets interfere with IME state

Safe patch that can fix weird IME bugs on pages with <select>s.
Attachment #513217 - Flags: approval2.0?
Attachment #513217 - Flags: approval2.0? → approval2.0+
Chris, can you write a test to make sure we don't regress this?
http://hg.mozilla.org/mozilla-central/rev/fb28cc7c6bb0
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Depends on: 676505
Comment 0 mentions:
"Once bug 610670 lands we'll be able to move that code out of PuppetWidget, but until then if we get near a release that might be worth band-aiding."

Bug 610670 is fixed now, so I guess that code can be moved out of PuppetWidget now?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: