631156 - Bug 628885 breaks non-libxul builds with an undefined reference error for CrashReporter::AppendAppNotesToCrashReport(nsACString_internal const&)

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[(no longer active)]

Making symlinks to the original object files in the archive libraries ../../chrome/src/libchrome_s.a ../ds/libxpcomds_s.a ../io/libxpcomio_s.a ../components/libxpcomcomponents_s.a ../threads/libxpcomthreads_s.a ../proxy/src/libxpcomproxy_s.a ../base/libxpcombase_s.a ../reflect/xptcall/src/libxptcall.a ../reflect/xptcall/src/libxptcmd.a ../reflect/xptinfo/src/libxptinfo.a ../../dist/lib/libxpt.a ../string/src/libstring_s.a
Undefined symbols:
  "CrashReporter::AppendAppNotesToCrashReport(nsACString_internal const&)", referenced from:
      _NS_DebugBreak_P in nsDebugImpl.o
ld: symbol(s) not found
collect2: ld returned 1 exit status

I have a patch which fixes this.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Whoever reviews this faster loves our developers on Mac more.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 509353 [details] [diff] [review]
Patch (v1)

(In reply to comment #1)
> Created attachment 509353 [details] [diff] [review]
> Patch (v1)
> 
> Whoever reviews this faster loves our developers on Mac more.

Don't misconstrue this; I just happened to be clearing my review queue ;).

Also, this patch is going to cause a crashreporter test to fail, but I don't think anyone cares.

Comment 3

[(no longer active)]

(In reply to comment #2)
> (In reply to comment #1)
> > Created attachment 509353 [details] [diff] [review]
> > Patch (v1)
> > 
> > Whoever reviews this faster loves our developers on Mac more.
> 
> Don't misconstrue this; I just happened to be clearing my review queue ;).

You should switch to Mac!  :P

> Also, this patch is going to cause a crashreporter test to fail, but I don't
> think anyone cares.

This wouldn't be the first test to fail on non-libxul, but as you suspect, nobody cares!  (We have tests which crash the browser on non-libxul, in case you're curious!)

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/e1d2e090c9a6

Comment 5

[(not currently active) Ted Mielczarek]

Can't wait till we kill non-libxul builds!

Comment 6

[(no longer active)]

Can't wait till we wait libxul builds fast!  ;)