Closed Bug 631248 Opened 13 years ago Closed 12 years ago

[compare-locales] DTD checker doesn't error on %S

Categories

(Mozilla Localizations :: Infrastructure, defect)

Product:
Mozilla Localizations
Component:
Infrastructure
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Pike, Unassigned)

Details

%foo; is a reference to a PE, and a broken PE reference is only a problem in the DTD, but not in content.

To catch stray %S errors in DTDs, I need to move from a xml doc template like

<foo>%s</foo>

to

<!DOCTYPE foo [
<!ENTITY bar "%s">
]>
<foo>&bar;</foo>

Not sure if I'll end up getting useful error reports on that, maybe I need to parse twice, once for good errors for the common case, and once to catch PE refs at all.
http://hg.mozilla.org/l10n/compare-locales/rev/839038b38c58 and http://hg.mozilla.org/l10n/compare-locales/rev/f844ad0e4c6e, fixed in 0.9.4.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.