Closed Bug 631271 Opened 11 years ago Closed 4 years ago

Don't ship with defaults/profile/prefs.js

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: Pike, Assigned: dbugs)

References

Details

Attachments

(1 file)

Bug 631271 - Don't ship with defaults/profile/prefs.js
59 bytes, text/x-review-board-request
benjamin
: review+
Details 
I think a bunch of defaults/profile died with omni.jar, but apparently we still have prefs.js for en-US builds, but not for l10n.

Not sure if that's a problem, but we should probably be consistent?

Spun off of bug 631222 comment 3.
It's not a problem. I wouldn't mind removing that file altogether, since it's pretty worthless.
Yep, let's drop defaults/profile/prefs.js.
Summary: Localized builds don't ship with defaults/profile/prefs.js → Don't ship with defaults/profile/prefs.js
Depends on: 768814
Assignee: nobody → dbugs
Attachment #8859171 - Flags: review?(benjamin)
Duplicate of this bug: 1351682
Comment on attachment 8859171 [details]
Bug 631271 - Don't ship with defaults/profile/prefs.js

https://reviewboard.mozilla.org/r/131210/#review134046

\o/ small victories
Attachment #8859171 - Flags: review?(benjamin) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fbab448119b7
Don't ship with defaults/profile/prefs.js r=bsmedberg
https://hg.mozilla.org/mozilla-central/rev/fbab448119b7
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 55 → mozilla55
You need to log in before you can comment on or make changes to this bug.