631296 - Mozmill.run raises the most recent exception, not necessarily the correct one

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

On disconnect, mozmill notes the disconnected status and attempts to
reraise the error:

https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/__init__.py#L257

However, this only raises the most recent exception.  If an exception
is encountered in the report_disconnect() or stop() method, then this
exception will be raised instead.

Comment 1

[Andrew Halberstadt [:ahal]]

Is this still an issue? If an exception happens in "report_disconnect" it won't be caught, so is it even possible to raise anything other than the DisconnectError?

Otherwise isn't the fix just:
try {
    ...
} catch DisconnectError, e:
    ...
    raise e

Comment 2

[Jeff Hammel]

It looks like this was fixed in https://github.com/mozautomation/mozmill/commit/a2af26231a8bbd0023c63c554166bfbbcb1f1d23#mozmill/mozmill/__init__.py as best I can tell; thanks for the vigilance, :ahal!