631415 - [Prod-only] Screenshot previews don't auto-appear/poll

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

For whatever reason, production only seems to poll a couple of times to check the status of the recently-uploaded screenshot, to generate the preview (after clicking Save).

See bug 628792 for background; it's the same bug, but since it works on preview, and was verified there, this is something else (assuming the code is there).

STR are the same as in bug 628792, but including again for posterity:

1. Log in to any of your test add-ons
2. Upload the following image, click Save
4. Wait for your screenshot to appear in the preview pane

If you have Admin access on prod, feel free to test using https://addons.mozilla.org/en-US/developers/addon/a9-9331/edit

Comment 1

[Jeff Balogh (:jbalogh)]

I have seen this a couple times. The image is requested and I get a 403. Then I open the link in a separate tab and I get a 200.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

http://screencast.com/t/l2Uvuf7s7 - the double images are (hopefully due to) someone else testing alongside me.

FTR, preview also throws up the 403:

[17:39:08.765] POST https://addons.allizom.org/en-US/developers/addon/a9-9331/upload_preview [HTTP/1.1 200 OK 6874ms]


[17:39:17.417] POST https://addons.allizom.org/en-US/developers/addon/a9-9331/edit_media/edit [HTTP/1.1 200 OK 1428ms]
[17:39:18.859] GET https://addons-cdn.allizom.org/img/uploads/previews/thumbs/53/53030.png?modified=1296783553 [HTTP/1.1 403 Forbidden 178ms]
[17:39:18.930] GET https://addons.allizom.org/en-US/developers/ajax/addon/a9-9331/image/status?_=1296783558834 [HTTP/1.1 200 OK 203ms]

Comment 3

[Wil Clouser [:clouserw]]

I read this whole thing and watched the screencast, but I don't know what the problem is (in the screencast, it looks like you left the page before it finished ajax loading?).  Can you post the actual results/expected results?

Comment 4

[Andy McKay]

We were wondering in IRC if the timing for the python polling and the actual image being on the CDN were slightly off. I've altered the JS to have two seperate polls now, one for icon and one for preview.

Comment 5

[Wil Clouser [:clouserw]]

Everything is hitting the same NFS mount (in fact, the CDN might even be a vhost alias).  Sounds like you're on it though, so -> andym

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> I read this whole thing and watched the screencast, but I don't know what the
> problem is (in the screencast, it looks like you left the page before it
> finished ajax loading?).  Can you post the actual results/expected results?

I left the page to demonstrate that the image is actually uploaded, but that isn't reflected in the preview/thumbnail.  The expected result is that, while remaining on the Edit page after uploading screenshots, the "AJAX-loading" image spins, the /image/status?=foo GET request keeps firing, and, once it's found the uploaded image, automatically replaces the AJAX-loading image with the thumbnail preview.

Comment 7

[Andy McKay]

Not completely sure this will fix things to be honest, but makes the screenshot polling independent of the python icon polling. So that if the NFS/CDN/whatever are out of sync it shouldn't matter.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #7)
> Not completely sure this will fix things to be honest, but makes the screenshot
> polling independent of the python icon polling. So that if the NFS/CDN/whatever
> are out of sync it shouldn't matter.

By "this," I'm assuming you mean https://github.com/jbalogh/zamboni/commit/0a142af48d28f23264bb725abc42dca3f2b4f7f7?

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Won't be able to test this in staging (since it's worked fine since the original fix).  I've regression-tested, and will keep doing so -- will verify in prod in 5.12.9.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Thanks for the fix, Andy!

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://addons.mozilla.org/en-US/developers/addon/a9-9331/edit.