Closed
Bug 631425
Opened 14 years ago
Closed 14 years ago
The homepage got slower
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
5.12.9
People
(Reporter: jbalogh, Assigned: andy+bugzilla)
Details
Attachments
(1 file)
|
66.98 KB,
image/jpeg
|
Details |
slow perf log
It may be a little premature to call this, but the homepage is 50% slower after the push according to the perf logs.
I'm guessing it's the changes to pulling featured add-ons. Why isn't that using Addon.featured? I think that one performs pretty well.
AddonManager.featured_ids does two values_list queries (which aren't cached) using gnarly-looking joins before it pulls featured add-ons.
I don't think the featured add-ons are going to get shuffled at all, so we're going to be stuck showing the same 4 all the time. The mobile homepage does its own thing but isn't very generic.
|
Assignee | |
Comment 1•14 years ago
|
||
Featured doesn't do the randomising by locale. It should just be a matter of altering featured_ids and caching that so it's faster.
|
|
Assignee | |
Comment 2•14 years ago
|
||
Moar caching. Hope this improves perf.
https://github.com/jbalogh/zamboni/commit/0f015f01c8effffc2a7b1249d155ebf1c7f76733
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•