Closed Bug 631493 Opened 9 years ago Closed 9 years ago

missing Firefox version in SeaMonkey's useragent string on OSX

Categories

(SeaMonkey :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
seamonkey2.1b3

People

(Reporter: adriank, Assigned: Callek)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The SeaMonkey 2.1 useragent string on Mac looks like this:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b11pre) Gecko/20110202 Firefox/ SeaMonkey/2.1b2pre

The Firefox version is clearly missing here.

The problem seems to exist since the very beginning of the introduction of "Firefox" in SeaMonkey's UA. I thought, it was a problem of my profile, but now I see that it's the same on new profiles too. That results in sites like AMO telling me that "this exstensions is not compatible with Firefox 2.1b2pre" (if using AMO through https://addons.mozilla.org/en-US/firefox/ ).
Dan, this appears to be a Mac OSX problem only. Any ideas?
Callek: build config problem?
Adrian, self build; downloaded build; etc.?

At least on windows I'm not seeing this as possible, nor am I noticing how it could be a build-config issue.

If self build, do you see FIREFOX_VERSION (and MOZ_US_FIREFOX_VERSION with a value in @objdir@/mozilla/config/autoconf.mk ?
Depends on: 581008
(In reply to comment #2)
> Adrian, self build; downloaded build; etc.?

Downloaded builds. I didn't try to build myself...

> At least on windows I'm not seeing this as possible, nor am I noticing how it
> could be a build-config issue.

(Mac-only problem)
Ok Investigation results:

generated autoconf.mk on both i386 and x86_64 had no FIREFOX_VERSION.

a patch of configure to verify what FIREFOX_VERSION should be, right after the cat verified it was blank, as well as that $topsrcdir was blank. Which is itself worrysome [will file a followup on that specific issue]

Anyway, $_topsrcdir should work, I verified that it has the right patch.

This is likely a problem with universal builds + comm-central; since Firefox mac builds are fine with the FIREFOX_VERSION properly set.
Assignee: nobody → bugspam.Callek
Status: NEW → ASSIGNED
Attachment #510133 - Flags: review?(khuey)
Comment on attachment 510133 [details] [diff] [review]
use $_topsrcdir and error if unset

Ship it, with a followup like we talked about.
Attachment #510133 - Flags: review?(khuey) → review+
FWIW, I don't think this needs approval, since it shouldn't affect Firefox at all.
http://hg.mozilla.org/mozilla-central/rev/71eb12acc8d3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
Blocks: 631955
VERIFIED with: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110207 Firefox/4.0b12pre SeaMonkey/2.1b3pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.