631593 - Retrieve actual scroll bar width when rendering thumbnails

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

We currently assume a static width of 25px for vertical scroll bars. We should retrieve the actual width and subtract that from window.innerWidth.

Comment 1

[Kevin Hanes]

bugspam

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

bugspam

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

bugspam

Comment 4

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 546468 [details] [diff] [review]
v1

document.body.clientWidth can exceed the view port, afaik.

Also, all this content-accessing code needs to go away for e10s.

Comment 6

[Raymond Lee [:raymondlee]]

(In reply to comment #5)
> Comment on attachment 546468 [details] [diff] [review] [review]
> v1
> 
> document.body.clientWidth can exceed the view port, afaik.
> 
> Also, all this content-accessing code needs to go away for e10s.

ok, I see.  I thought the clientWidth presents the width view port (based on https://developer.mozilla.org/en/DOM/element.clientWidth).

Any suggestions how I can get the vertical scrollbar width?

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

(In reply to comment #6)
> Any suggestions how I can get the vertical scrollbar width?

IIRC, this is not implemented, yet (in gecko) but someone said that it shouldn't be too difficult. So maybe we should open a bug for the enhancement and let it block this one.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

bugspam

(Fx7 was branched, removing open bugs from Fx7 meta bug, we won't create new meta bugs for upcoming Fx versions)

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

Will be fixed by bug 727765.

Comment 10

[Justin Dolske [:Dolske]]

Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.

If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.

See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.

We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.