631802 - Provide password doorhangers in popups with no history

Status: RESOLVED DUPLICATE of bug 784028

(Toolkit :: Password Manager, defect)

Description

[Stefan]

User-Agent:       
Build Identifier: 4.0b12pre Built from http://hg.mozilla.org/mozilla-central/rev/7cb3e9795d04

There are D-Link routers which prompt for username/password in a popup window. This window is closed when the form is submitted. A (possible) doorhanger, prompting for allowance to remember the password, disappears.

Reproducible: Always

Steps to Reproduce:
1. open testcase, press new window
2. left click into first input field
3. type a-tab-a-tab-space
Actual Results:  
· window closes
· no opportunity to confirm password remembrance

Expected Results:  
provide an opportunity to confirm allowance to remember the password 

(Theres a problem with the doorhanger anyway: The first time the form is filled out no doorhanger pops up. Not until the second time you fill it out the prompt appears, cf. login2-noclose.html).

Comment 1

[Stefan]

Attachment: testcase

Comment 2

[Stefan]

Attachment: login2-noclose.html not closing the window

Comment 3

[Stefan]

(There is an annoying security warning, closing the doorhanger/remember password prompt. You better store and open the testcases on your local machine).

Comment 4

[George Carstoiu]

Mozilla/5.0 (X11; Linux i686; rv:2.0b12pre) Gecko/20110208 Firefox/4.0b12pre

Just to make sure I understand. Your problem is that in the first testcase there is not enough time for the doorhanger to appear in order to give the user the possibility to save its credentials before the pop-up closes?

Comment 5

[Stefan]

Almost. To put it differently: The doorhanger is attached to the wrong window. In FF 3.x (if only my testcase would work) the doorhanger is on the "main" window.

Comment 6

[Stefan]

So. I put it on my server:

http://www.vogtner.de/moztestcases/login2.html

With FF 3.5 the user is prompted in the "main" window. If you disable the close you'll see the different Bug 631800.

Comment 7

[u279076]

We should probably display the doorhanger in the window/tab where the pageLoad occurs post-login.

Comment 9

[George Carstoiu]

There is also an exception being thrown:

Error: [Exception... "'PopupNotifications_show: invalid browser' when calling
method: [nsILoginManagerPrompter::promptToSavePassword]"  nsresult: "0x8057001e
(NS_ERROR_XPC_JS_THREW_STRING)"  location: "JS frame ::
resource://gre/components/nsLoginManager.js :: <TOP_LEVEL> :: line 959"  data:
no]
Source File: resource://gre/components/nsLoginManager.js
Line: 959

Comment 10

[Loic]

Same exception in error console when I'm trying to report a bug on YouTube with Firefox 17:

1) Open http://www.youtube.com/
2) Scroll to bottom and click on 'Report a bug' (http://www.google.com/tools/feedback/intl/en/error.html)
3) Click on 'Sign In'

Error: [Exception... "'PopupNotifications_show: invalid browser' when calling method: [nsILoginManagerPrompter::promptToSavePassword]"  nsresult: "0x8057001e (NS_ERROR_XPC_JS_THREW_STRING)"  location: "JS frame :: resource:///components/nsLoginManager.js :: <TOP_LEVEL> :: line 938"  data: no]
Source File: resource:///components/nsLoginManager.js
Line: 938

Comment 11

[Matthew N. [:MattN]]

Running this testcase with the patch in bug 784028 will cause it to show a doorhanger in the opener's tab.

Comment 12

[Matthew N. [:MattN]]

I think the a possible solution is to also show the doorhanger in a dismissed state (possibly after a delay of 1-2s) in the popup and remove the doorhanger from the opener after a timeout.  The dismissed state and possible delay in the popup is to avoid a distraction in case the window is going to close immediately after submission. Removing the doorhanger from the opener after a delay handles the case where the popup doesn't close so that a doorhanger doesn't linger there unexpectedly. If an action is taken on a doorhanger in either window, remove the doorhanger in the other.

Comment 13

[Stefan]

(In reply to Matthew N. [:MattN] from comment #11)
> Running this testcase with the patch in bug 784028 will cause it to show a
> doorhanger in the opener's tab.

I have checked attachment 667372 [details] [diff] [review] which works if the window is closed upon form submission.  If the window stays open no doorhanger appears:

http://www.vogtner.de/mozilla/631802/

Comment 14

[Stefan]

It was attachment 667235 [details] [diff] [review] not attachment 667372 [details] [diff] [review] which i checked.

Comment 15

[Stefan]

This issue is fixed with
https://bugzilla.mozilla.org/show_bug.cgi?id=784028#c16

Comment 16

[Matthew N. [:MattN]]

We are keeping this bug open to address the issue of when the popup remains open. See comment 12 and 13.

Comment 17

[Stefan]

Oops. Meanwhile I've filed Bug 798134 for that purpose. Feel free to close whichever fits worst.