The default bug view has changed. See this FAQ.

Should remove event listener for "load" event.

RESOLVED FIXED in Firefox 7

Status

()

Firefox
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

unspecified
Firefox 7
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
From http://tinderbox.mozilla.org/showlog.cgi?tree=Firefox&errorparser=unittest&logfile=1296868329.1296870408.6910.gz&buildtime=1296868329&buildname=Rev3%20MacOSX%20Leopard%2010.5.8%20mozilla-central%20debug%20test%20mochitest-other&fulltext=1


TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_bug581242.js | Current tab should be blank tab
++DOMWINDOW == 215 (0x282a1bf4) [serial = 575] [outer = 0x2829a5a0]
pldhash: for the table at address 0x296e6868, the given entrySize of 48 probably favors chaining over double hashing.
++DOCSHELL 0x296e6800 == 78
++DOMWINDOW == 216 (0x2871b254) [serial = 576] [outer = 0x0]
++DOMWINDOW == 217 (0x2877d974) [serial = 577] [outer = 0x2871b210]
WARNING: NS_ENSURE_TRUE(sf) failed: file /builds/slave/cen-osx-dbg/build/docshell/base/nsDocShell.cpp, line 4986
WARNING: NS_ENSURE_TRUE(sf) failed: file /builds/slave/cen-osx-dbg/build/docshell/base/nsDocShell.cpp, line 4986
++DOMWINDOW == 218 (0x2879c674) [serial = 578] [outer = 0x2871b210]
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_bug581242.js | about:addons should load into blank tab.
JavaScript strict warning: chrome://mochitests/content/browser/browser/base/content/test/browser_bug581242.js, line 48: reference to undefined property browser.currentURI

Checking browser.currentURI.spec is invoked twice, since "load" event listener is not removed.
(Assignee)

Comment 1

6 years ago
Created attachment 510052 [details] [diff] [review]
remove the event listener
Attachment #510052 - Flags: review?(dao)
(In reply to comment #0)
> Checking browser.currentURI.spec is invoked twice, since "load" event listener
> is not removed.

Why would this happen? That tab gets removed when the first load event is handled, no?
(Assignee)

Comment 3

6 years ago
(In reply to comment #2)
> (In reply to comment #0)
> > Checking browser.currentURI.spec is invoked twice, since "load" event listener
> > is not removed.
> 
> Why would this happen? That tab gets removed when the first load event is
> handled, no?

I am not sure the reason but the second load event came from at:

http://hg.mozilla.org/mozilla-central/file/f40e9a9977e2/browser/base/content/tabbrowser.xml#l1638

Is this a bug of tabbrowser.xml?

Updated

6 years ago
Attachment #510052 - Flags: review?(dao) → review+
(Assignee)

Updated

6 years ago
Assignee: nobody → hiikezoe
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/57bedceef898
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
Verified changes were submited to file browser/base/content/test/browser_bug581242.js in mozilla repository.

Is this enough to mark the busg as VERIFIED-FIXED? Or are there any other tests that need to be run to verify this?

Thanks!
You need to log in before you can comment on or make changes to this bug.