631848 - status panel causes artifact during page loading

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Timothy Nikkel (:tnikkel)]

Every time I load http://www.ourbombers.com on Linux or Windows I get a dark blue artifact around the status panel just before the page contents show up.

I know why it happens. I don't know what to do about it.

Comment 1

[Timothy Nikkel (:tnikkel)]

So the basic problem here is that we don't send an invalidate when what we paint changes. In this case we don't get an invalidate when we go from drawing the previous page's view to using the new page's view. In this case the removal of the previous page's root view in DocumentViewerImpl::Destroy does not cause an invalidate. This is because the PresShell::Freeze just just above in that function sets painting to be suppressed on that document, so the invalidate that the view removal causes just dies. The obvious fix is to just make sure that invalidate happens using a flag or something to force it.

There is a time period when loading a new page where we have a choice for what to draw. (1) We can draw the previous page. (2) Or we can draw the background color only of the new page (even if the new page has some content). In bug 593892 I changed us from doing (1) to doing (2) to fix a bug. No one seems to have noticed or complained. But with this bug fixed we could do (1) or (2). (If we went with (1) we'd have to invalidate in PresShell::InitialReflow where we create the root frame.)

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Comment 3

[Timothy Nikkel (:tnikkel)]

I tryservered this, ready to land.

Comment 4

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/4e01315e79d3

Comment 5

[Alex Lakatos[:AlexLakatos]]

Attachment: screenshot

Is this what you were talking about? This still happens on Build identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b12pre) Gecko/20110216 Firefox/4.0b12pre

Comment 6

[Timothy Nikkel (:tnikkel)]

Nope, that is not what this bug was about. That happens at least as far back as Firefox 3.6.