631901 - Save dialog boxes missing

Status: RESOLVED INVALID

(SeaMonkey :: Download & File Handling, defect)

Description

[Stefan Haas]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b12pre) Gecko/20110204 Firefox/4.0b12pre SeaMonkey/2.1b3pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b12pre) Gecko/20110204 Firefox/4.0b12pre SeaMonkey/2.1b3pre

Any kind of "Save as" dialog box (pop) missing:
Save page as
Save link as
Save image as

Reproducible: Always

Steps to Reproduce:
1. Select any resource
2. Right-click or menu pull-down for saving
3. Nothing happens instead of pop-up appearing and background application waiting
Actual Results:  
Not able to save any resource

Expected Results:  
Saving of resource to a local folder via popup (or default location)

Image can be saved via dragging resource to desktop/explorer folder

Comment 1

[Philip Chee]

Confirming. The only recent change in toolkit is bug 622684 and that's all IFDEFed Android. Possible fallout from omnijar?

Comment 2

[Robert Kaiser]

I don't think omnijar has anything to do with that. And it WFM on a Linux build from today.

Comment 3

[Stefan Haas]

I used a different user profile and the save boxes re-appear. What system-dependence may cause the disappered (Explorere DLL) Popups?

Besides, also the popup for the default download location is affected ...

Comment 4

[Philip Chee]

Ah the difference seems to be the following pref:
user_pref("browser.download.manager.showWhenStarting", false);
Which is present in my existing profile but not in a new profile.

Aha.


http://hg.mozilla.org/comm-central/pushloghtml?changeset=ddb25b1eeab1
https://bugzilla.mozilla.org/show_bug.cgi?id=576970
author	Jens Hatlak <[e-mail]>
	Thu Jan 27 23:32:31 2011 +0100 (at Thu Jan 27 23:32:31 2011 +0100)

http://hg.mozilla.org/comm-central/rev/ddb25b1eeab1#l1.25
1.25 +pref("services.sync.prefs.sync.browser.download.manager.showWhenStarting", true);
This must have been sync'ed from a SM 2.0 profile where this was set to false.

Comment 5

[[e-mail]]

What's the value of your browser.download.useDownloadDir preference?

Comment 6

[Philip Chee]

My 2.0 profile with Sync/Weave extension installed had "browser.download.manager.showWhenStarting" set to false and must have been sync'ed to the cloud.

Hypothesis: When syncUI landed in 2.1 this preference got copied over.

Comment 7

[Philip Chee]

> What's the value of your browser.download.useDownloadDir preference?
Not in my 2.0 profile and not in my 2.1 profile prefs.js

about:config says:
browser.download.useDownloadDir;false

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

I cannot reproduce this. What are the *exact* STR? (Note: I'm on Win7)

Comment 9

[Philip Chee]

Create a SM2.0 profile.
Install Weave/Sync.
Set browser.download.manager.showWhenStarting to false.
Use it a bit.

Create a 2.1 profile
Use a 2.1 nightly with the Sync UI.
Run Sync.
Try to download anything. It downloads but no UI appears so people assume that the download failed or didn't start at all.

Comment 10

[Robert Kaiser]

OK, so the bug is not "Save dialogs missing" but rather "Unintentionally (?) switching to non-prompted dialogs via Sync". That's a relief, as this is not a beta blocker, then. It may be relnote-worthy, but first we need to figure out if this is really unintentionally or not.

Comment 11

[Phoenix]

Looks like correct behavior, if setting is in scope of Sync, why it shouldn't be synced? Closing as invalid, feel free to reopen if you think that something should be improved here