631914 - "Oops! We had an error." when trying to edit versions in certain add-ons

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Michael Kraft [:morac]]

In two of my add-ons, Yahoo! Mail Notifier and DSLR Notifier 2, if I go to the "Manage Status & Versions" and click on any version of the add-on, I get an error page with the following wording:

---------------------------------------------------------------------
Oops! We had an error.

We'll get to fixing that soon.

You can try refreshing the page, or head back to the Add-ons homepage.
---------------------------------------------------------------------


Currently I can't update versions for either of those add-ons.  I can run a validation test on the version.  I haven't tried uploading a new version so I don't know if that would work or not, but one of them had a new version added on January 12th 2011.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Sorry about that, Michael; here's the stack trace (for the developers to fix):

Traceback (most recent call last):

  File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/core/handlers/base.py", line 109, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/amo_python/www/prod/zamboni/apps/amo/decorators.py", line 77, in wrapper
    return f(*args, **kw)

  File "/data/amo_python/www/prod/zamboni/apps/amo/decorators.py", line 69, in wrapper
    return f(*args, **kw)

  File "/usr/lib/python2.6/contextlib.py", line 34, in __exit__
    self.gen.throw(type, value, traceback)

  File "/data/amo_python/www/prod/zamboni/apps/amo/models.py", line 36, in skip_cache
    yield

  File "/data/amo_python/www/prod/zamboni/apps/amo/decorators.py", line 69, in wrapper
    return f(*args, **kw)

  File "/data/amo_python/www/prod/zamboni/apps/addons/decorators.py", line 22, in wrapper
    return f(request, addon, *args, **kw)

  File "/data/amo_python/www/prod/zamboni/apps/amo/decorators.py", line 24, in wrapper
    return func(request, *args, **kw)

  File "/data/amo_python/www/prod/zamboni/apps/devhub/views.py", line 71, in wrapper
    return fun()

  File "/data/amo_python/www/prod/zamboni/apps/devhub/views.py", line 60, in <lambda>
    **kw)

  File "/data/amo_python/www/prod/zamboni/apps/devhub/views.py", line 696, in version_edit
    queryset=version.apps.all())

  File "/data/amo_python/www/prod/zamboni/apps/devhub/forms.py", line 327, in __init__
    super(BaseCompatFormSet, self).__init__(*args, **kw)

  File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/forms/models.py", line 439, in __init__
    super(BaseModelFormSet, self).__init__(**defaults)

  File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/forms/formsets.py", line 47, in __init__
    self._construct_forms()

  File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/forms/formsets.py", line 97, in _construct_forms
    self.forms.append(self._construct_form(i))

  File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/forms/models.py", line 464, in _construct_form
    return super(BaseModelFormSet, self)._construct_form(i, **kwargs)

  File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/forms/formsets.py", line 116, in _construct_form
    form = self.form(**defaults)

  File "/data/amo_python/www/prod/zamboni/apps/devhub/forms.py", line 311, in __init__
    self.app = amo.APP_IDS[int(app)]

KeyError: 2

Comment 2

[Jeff Balogh (:jbalogh)]

https://github.com/jbalogh/zamboni/commit/ab2047c 

(In reply to comment #0)
> Currently I can't update versions for either of those add-ons.  I can run a
> validation test on the version.  I haven't tried uploading a new version so I
> don't know if that would work or not, but one of them had a new version added
> on January 12th 2011.

The fix for this will go out on Thursday and these versions will be editable. Uploading a new version should be fine (especially if it doesn't claim to support the Mozilla Suite) or you can ask an admin to remove the Mozilla Suite support from your current versions.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; https://addons.allizom.org/en-US/developers/addon/yahoo-mail-notifier/versions/125819 is working for me, now, where before it was throwing a traceback.  Will also do some testing around versions.

Comment 4

[Michael Kraft [:morac]]

(In reply to comment #2)
> The fix for this will go out on Thursday and these versions will be editable.
> Uploading a new version should be fine (especially if it doesn't claim to
> support the Mozilla Suite) or you can ask an admin to remove the Mozilla Suite
> support from your current versions.

Did the fix go out on Thursday as planned?  The reason I ask, is that I'm still getting the error today (Saturday).

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #4)
 
> Did the fix go out on Thursday as planned?  The reason I ask, is that I'm still
> getting the error today (Saturday).

Sadly, apparently not, as I just saw the tracebacks with the same stack.  Wil, any chance we can (re) push the fix now, instead of waiting for Thursday?

Comment 6

[Jeff Balogh (:jbalogh)]

We'll try again sometime soon.

Comment 7

[Jeff Balogh (:jbalogh)]

https://addons.mozilla.org/en-US/developers/addon/yahoo-mail-notifier/versions/125819 works now.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #7)
> https://addons.mozilla.org/en-US/developers/addon/yahoo-mail-notifier/versions/125819
> works now.

As does https://addons.mozilla.org/en-US/developers/addon/dslr-notifier-2/edit (I didn't touch anything), now.

Verified FIXED with today's 5.12.9.4 push.