Closed
Bug 631916
Opened 13 years ago
Closed 13 years ago
Make about:support code use MailServices
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.3a3
People
(Reporter: rain1, Assigned: rain1)
References
Details
Attachments
(1 file, 1 obsolete file)
|
4.92 KB,
patch
|
bwinton
:
review+
|
Details | Diff | Splinter Review |
I'm not even going to try to make all our code use MailServices, but this code is fairly new and only has a few uses. (I'm not completely happy with MailServices.accounts.accounts, so I wouldn't mind changing that to something like MailServices.acctMgr.)
Attachment #510127 -
Flags: review?(bwinton)
|
Assignee | |
Comment 1•13 years ago
|
||
Now that we have the SMTP service in MailServices too (bug 633345), we can use that as well.
Attachment #510127 -
Attachment is obsolete: true
Attachment #511685 -
Flags: review?(bwinton)
Attachment #510127 -
Flags: review?(bwinton)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 511685 [details] [diff] [review] replace the SMTP service too Looks good to me, assuming all the tests still pass.
Attachment #511685 -
Flags: review?(bwinton) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/comm-central/rev/b7745c73fc08
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a3
You need to log in
before you can comment on or make changes to this bug.
Description
•