631954 - Right-clicking on back button menu item opens additional back button menu

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Tobias (:Tobbi) Markus]

When right-clicking any item in the back button menu, an obsolete back button menu opens at the point that was clicked.

I think this is obsolete and doesn't belong here.

See this screen cast for more details:
http://screencast.com/t/iNgz3VwjQ0Kz

Comment 1

[Tobias (:Tobbi) Markus]

The issue is that it's registering that click for the underlying back arrow which displays the menu on right-click.

Is this WONTFIX then?

Comment 2

[(mostly gone) XtC4UaLL [:xtc4uall]]

Confirmed with Mozilla/5.0 (Windows NT 5.1; rv:2.0b12pre) Gecko/20110207 Firefox/4.0b12pre ID:20110207030345.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Is that a regression from 3.6?

Comment 4

[Tobias (:Tobbi) Markus]

(In reply to comment #3)
> Is that a regression from 3.6?

Looks like one. When I click on an item in this dropdown in 3.6, no additional menu is opened.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Would be great if you could check for the regression range.

Comment 6

[Tobias (:Tobbi) Markus]

(In reply to comment #5)
> Would be great if you could check for the regression range.

Last good nightly: 2010-10-18 First bad nightly: 2010-10-19

Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cfd18201f49b&tochange=c9df0c5cbf8c

From the pushlog it looks like the patch for Bug 582485 caused this.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #6)
> From the pushlog it looks like the patch for Bug 582485 caused this.

Margarete, would that make sense to you?

Comment 8

[:Margaret Leibovic]

That makes sense, but I can't reproduce this problem on OSX. It seems like the patch in bug 582485 probably exposed some underlying platform-specific issue, since the main thing it did was just take out some "#ifdef XP_MACOSX" lines.

Comment 10

[Dão Gottwald [:dao]]

Attachment: patch

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 514052 [details] [diff] [review]
patch

I don't understand this patch. Where does this element get a non-empty "context" attribute (it's not defined in the XUL)? Why does "context" on a menupopup have any effect to begin with?

Comment 12

[Dão Gottwald [:dao]]

#unified-back-forward-button has context="backForwardMenu". The cloned popups don't have a context attribute set without this patch.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Seems odd that menupopups inherit "context" from their parents (particularly when they are themselves a context menu...). Shouldn't we fix that?

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Also, why doesn't this affect other menupopups similarly? Is it because the click-and-hold code opens the popup manually?

Comment 15

[Dão Gottwald [:dao]]

The cloned popups don't act as context menus. This actually affects other popup menus, like the all-tabs dropdown menu.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 514052 [details] [diff] [review]
patch

I can't seem to reproduce this bug anymore (tried Linux/Mac/Windows). Can someone else confirm?

Comment 17

[Dão Gottwald [:dao]]

I can easily reproduce this on Windows.

Comment 18

[Chris B.]

(In reply to comment #17)
> I can easily reproduce this on Windows.

I am using the 5/17/11 Nightly and do NOT experience this issue any more, as shown in the original uploaded video from comment 0.  When right-clicking the Back Button, you correctly receive the list of previously opened tabs.  Now, if I right-click on one of those entries, Nightly doesn't generate another list of previous tabs, but instead takes me to that page.  If THIS right-click action to take me to the page listed is in fact a bug (and only the left-click should be enabled here), let me know and I will file it on Bugzilla.

Comment 19

[Chris B.]

(In reply to comment #18)
> (In reply to comment #17)
> > I can easily reproduce this on Windows.
> 
> I am using the 5/17/11 Nightly and do NOT experience this issue any more, as
> shown in the original uploaded video from comment 0.  When right-clicking
> the Back Button, you correctly receive the list of previously opened tabs. 
> Now, if I right-click on one of those entries, Nightly doesn't generate
> another list of previous tabs, but instead takes me to that page.  If THIS
> right-click action to take me to the page listed is in fact a bug (and only
> the left-click should be enabled here), let me know and I will file it on
> Bugzilla.

In case it helps.....I am running Windows 7 64-Bit (but the 32-Bit version of Nightly = http://hg.mozilla.org/mozilla-central/rev/f717485edc51).

Comment 20

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #18)
> When right-clicking the Back Button, you correctly receive the list of
> previously opened tabs. Now, if I right-click on one of those entries, Nightly
> doesn't generate another list of previous tabs, but instead takes me to that
> page.

I see this too. I even tested all of WinXP/Vista/Win7.

Comment 21

[Dão Gottwald [:dao]]

You hold the back button for the menu to appear, then you right-click the menu. I think this bug is just wrongly summarized.

Comment 22

[Dão Gottwald [:dao]]

Well, the summary isn't even wrong after all... I just failed to read it properly.

Comment 23

[Dão Gottwald [:dao]]

Comment on attachment 514052 [details] [diff] [review]
patch

And I can reproduce this on Linux as well.

Comment 24

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 514052 [details] [diff] [review]
patch

add a comment? something like "prevent the context attribute on unified-back-forward-button from being inherited"

Comment 25

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/48588658ad9a

Comment 26

[Simona Badau, Desktop QA]

(In reply to comment #23)
> Comment on attachment 514052 [details] [diff] [review] [review]
> patch
> 
> And I can reproduce this on Linux as well.

The behavior described in Comment 18 is still reproducible. Is this ok?