Right-clicking on back button menu item opens additional back button menu

RESOLVED FIXED in Firefox 6

Status

()

Firefox
Menus
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Tobbi, Assigned: dao)

Tracking

({regression})

Trunk
Firefox 6
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
When right-clicking any item in the back button menu, an obsolete back button menu opens at the point that was clicked.

I think this is obsolete and doesn't belong here.

See this screen cast for more details:
http://screencast.com/t/iNgz3VwjQ0Kz
(Reporter)

Comment 1

6 years ago
The issue is that it's registering that click for the underlying back arrow which displays the menu on right-click.

Is this WONTFIX then?
Confirmed with Mozilla/5.0 (Windows NT 5.1; rv:2.0b12pre) Gecko/20110207 Firefox/4.0b12pre ID:20110207030345.
Is that a regression from 3.6?
(Reporter)

Comment 4

6 years ago
(In reply to comment #3)
> Is that a regression from 3.6?

Looks like one. When I click on an item in this dropdown in 3.6, no additional menu is opened.
Would be great if you could check for the regression range.
Keywords: regression, regressionwindow-wanted
(Reporter)

Comment 6

6 years ago
(In reply to comment #5)
> Would be great if you could check for the regression range.

Last good nightly: 2010-10-18 First bad nightly: 2010-10-19

Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cfd18201f49b&tochange=c9df0c5cbf8c

From the pushlog it looks like the patch for Bug 582485 caused this.
Keywords: regressionwindow-wanted
(In reply to comment #6)
> From the pushlog it looks like the patch for Bug 582485 caused this.

Margarete, would that make sense to you?

Comment 8

6 years ago
That makes sense, but I can't reproduce this problem on OSX. It seems like the patch in bug 582485 probably exposed some underlying platform-specific issue, since the main thing it did was just take out some "#ifdef XP_MACOSX" lines.
Blocks: 582485
Duplicate of this bug: 635631
(Assignee)

Updated

6 years ago
Assignee: nobody → dao
(Assignee)

Comment 10

6 years ago
Created attachment 514052 [details] [diff] [review]
patch
Attachment #514052 - Flags: review?(gavin.sharp)
(Assignee)

Updated

6 years ago
OS: Windows 7 → All
Hardware: x86 → All
(Assignee)

Updated

6 years ago
Attachment #514052 - Flags: review?(dolske)
Comment on attachment 514052 [details] [diff] [review]
patch

I don't understand this patch. Where does this element get a non-empty "context" attribute (it's not defined in the XUL)? Why does "context" on a menupopup have any effect to begin with?
(Assignee)

Comment 12

6 years ago
#unified-back-forward-button has context="backForwardMenu". The cloned popups don't have a context attribute set without this patch.
Seems odd that menupopups inherit "context" from their parents (particularly when they are themselves a context menu...). Shouldn't we fix that?
Also, why doesn't this affect other menupopups similarly? Is it because the click-and-hold code opens the popup manually?
(Assignee)

Comment 15

6 years ago
The cloned popups don't act as context menus. This actually affects other popup menus, like the all-tabs dropdown menu.
Comment on attachment 514052 [details] [diff] [review]
patch

I can't seem to reproduce this bug anymore (tried Linux/Mac/Windows). Can someone else confirm?
Attachment #514052 - Flags: review?(gavin.sharp)
Attachment #514052 - Flags: review?(dolske)
(Assignee)

Comment 17

6 years ago
I can easily reproduce this on Windows.

Comment 18

6 years ago
(In reply to comment #17)
> I can easily reproduce this on Windows.

I am using the 5/17/11 Nightly and do NOT experience this issue any more, as shown in the original uploaded video from comment 0.  When right-clicking the Back Button, you correctly receive the list of previously opened tabs.  Now, if I right-click on one of those entries, Nightly doesn't generate another list of previous tabs, but instead takes me to that page.  If THIS right-click action to take me to the page listed is in fact a bug (and only the left-click should be enabled here), let me know and I will file it on Bugzilla.

Comment 19

6 years ago
(In reply to comment #18)
> (In reply to comment #17)
> > I can easily reproduce this on Windows.
> 
> I am using the 5/17/11 Nightly and do NOT experience this issue any more, as
> shown in the original uploaded video from comment 0.  When right-clicking
> the Back Button, you correctly receive the list of previously opened tabs. 
> Now, if I right-click on one of those entries, Nightly doesn't generate
> another list of previous tabs, but instead takes me to that page.  If THIS
> right-click action to take me to the page listed is in fact a bug (and only
> the left-click should be enabled here), let me know and I will file it on
> Bugzilla.

In case it helps.....I am running Windows 7 64-Bit (but the 32-Bit version of Nightly = http://hg.mozilla.org/mozilla-central/rev/f717485edc51).
(In reply to comment #18)
> When right-clicking the Back Button, you correctly receive the list of
> previously opened tabs. Now, if I right-click on one of those entries, Nightly
> doesn't generate another list of previous tabs, but instead takes me to that
> page.

I see this too. I even tested all of WinXP/Vista/Win7.
(Assignee)

Comment 21

6 years ago
You hold the back button for the menu to appear, then you right-click the menu. I think this bug is just wrongly summarized.
(Assignee)

Comment 22

6 years ago
Well, the summary isn't even wrong after all... I just failed to read it properly.
(Assignee)

Comment 23

6 years ago
Comment on attachment 514052 [details] [diff] [review]
patch

And I can reproduce this on Linux as well.
Attachment #514052 - Flags: review?(gavin.sharp)
Comment on attachment 514052 [details] [diff] [review]
patch

add a comment? something like "prevent the context attribute on unified-back-forward-button from being inherited"
Attachment #514052 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 25

6 years ago
http://hg.mozilla.org/mozilla-central/rev/48588658ad9a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
(In reply to comment #23)
> Comment on attachment 514052 [details] [diff] [review] [review]
> patch
> 
> And I can reproduce this on Linux as well.

The behavior described in Comment 18 is still reproducible. Is this ok?
You need to log in before you can comment on or make changes to this bug.