Closed Bug 632048 Opened 11 years ago Closed 11 years ago

Bookmark popup auto hides too quickly on page bookmarked

Categories

(Firefox for Android Graveyard :: Bookmarks, defect, P2)

ARM
Android
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 5

People

(Reporter: aaronmt, Assigned: mbrubeck)

Details

(Keywords: polish, Whiteboard: [fennec-checkin-postrc])

Attachments

(3 files)

Mozilla/5.0 (Android; Linux armv7l; rv:2.0b12pre) Gecko/20110207 Firefox/4.0b12pre Fennec/4.0b5pre

Currently when a page is starred, the timeout for auto-hide (if auto-hide is even necessary) is too quick at two seconds. This should be raised to four-seconds or perhaps auto-hide removed.

http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser-ui.js#1077
http://mxr.mozilla.org/mobile-browser/source/chrome/content/BookmarkPopup.js#38

Device: HTC Nexus One
Android: 2.2.2
Priority: -- → P2
I'm seeing this on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b13pre) Gecko/20110311 Firefox/4.0b13pre Fennec/4.0b6pre
tracking-fennec: --- → ?
Assignee: nobody → mbrubeck
Keywords: polish
This still has some problems if the UI is bogged down.  The first time the popup is shown, it can take close to 5 seconds (or more!) for layout to finish and the popup to actually appear.
I like this better.
Attachment #518809 - Flags: review?(mark.finkle)
(In reply to comment #3)
> Created attachment 518809 [details] [diff] [review]
> don't auto-hide bookmark popup
> 
> I like this better.

Yes, was wondering why the reason for auto-hide in the first place.
Comment on attachment 518809 [details] [diff] [review]
don't auto-hide bookmark popup

We did this originally because the use case was: user wants to bookmark a page and move on

So it seemed like auto-hiding the popup was the best choice. Now it is easy to dismiss the popup with a tap, so maybe we don't need the auto-hide. I'd vote to remove it.

Madhava needs final say.
Attachment #518809 - Flags: ui-review?(madhava)
Attachment #518809 - Flags: review?(mark.finkle)
Attachment #518809 - Flags: review+
I think I could live without the timer.  At the time, as Mark describes, it was about getting it out of the way -- they're non-primary options, but the dialog helps to explain what you've just done (a lot of people out there still don't understand that starring and bookmarking are the same thing) and shows people that you can actually do these things.  BUT, given that the very next step for people is going to be to put a finger down outside the dialog in order to get back to where they were, the tap outside to dismiss isn't really an _extra_ tap/click the way it would be on desktop.
Attachment #518809 - Flags: ui-review?(madhava) → ui-review+
Attachment #518809 - Flags: approval2.0?
Let's wait for post RC
Whiteboard: [fennec-checkin-postrc]
tracking-fennec: ? → ---
Attachment #518809 - Flags: approval2.0?
http://hg.mozilla.org/mobile-browser/rev/502f112e69c3
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attached patch Test fixSplinter Review
Broke a test... well... made a test irrelevant.
Attachment #520351 - Flags: review?(mbrubeck)
Attachment #520351 - Flags: review?(mbrubeck) → review+
(In reply to comment #10)
> Pushed test fix: http://hg.mozilla.org/mobile-browser/rev/3fa9692ebcb4

Maybe we should just remove the test altogether.
Verified on build: Mozilla /5.0 (Android;Linux armv7l;rv:2.2a1pre)
Gecko/20110405 Firefox/4.2a1pre Fennec /4.1a1pre 
Device: Samsung Captivate (Android 2.2 update 1)
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 5
You need to log in before you can comment on or make changes to this bug.