Created attachment 510307 [details] [diff] [review] Do not create new functions for every kinetic pan
Created attachment 565128 [details] [diff] [review] patch v2 This patch was badly bit-rotted. This updates Ben's approach to work against the current code, and again prevent us from creating new objects or functions on each kinetic pan.
Created attachment 565129 [details] [diff] [review] patch v2 (diff -w) Here's a "diff -w" output, to make it easier to separate the real changes from the indentation changes.
Comment on attachment 565128 [details] [diff] [review] patch v2 The priginal worry was related to methodjit, which is off in chrome now. Inany case, this shouldn't hurt.
Created attachment 565131 [details] [diff] [review] s/self/this/g This mechanical patch removes the now-unnecessary "self" local and replaces it with "this" inside onBeforePaint. I'll fold this into the main patch before pushing it; just keeping it separate for now to keep reviews easier.
(In reply to Mark Finkle (:mfinkle) from comment #4) > The priginal worry was related to methodjit, which is off in chrome now. > Inany case, this shouldn't hurt. True, though this should at least reduce the amount of garbage collection we do. It will also help if we manage to fix the methodjit memory usage enough to turn it back on.
Backed out because this broke kinetic panning on repeated swipes: https://hg.mozilla.org/mozilla-central/rev/737e0ebf68b2 I'll go back and see what I messed up...
This code is going away in favor of AsyncPanZoomController.