Make psmglue statically link to cmt & protocol for OS/2

VERIFIED FIXED

Status

P5
normal
VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: jhpedemonte, Assigned: javi)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
Under OS/2, we are creating dll's for cmt and protocol.  Rather than 
do this, we should statically link to the cmt and protocol libraries.  
This prevents name clashes with other dll's.
(Reporter)

Comment 1

18 years ago
Created attachment 20891 [details] [diff] [review]
OS/2 changes for static linking

Comment 2

18 years ago
r=cls on the patch.  Reassigning to javi as I believe the security partition is
locked down.
Assignee: cls → javi
(Assignee)

Comment 3

18 years ago
cls, did you test his under other platforms to make sure they still work?

Could one of you get this super-reviewed first so that I can just check in.

Comment 4

18 years ago
No, I didn't because the changes were straightforward. I'll throw it into my
next round of builds.

Comment 5

18 years ago
Tested the changes under linux.  sr=cls
(Assignee)

Comment 6

18 years ago
I don't have a clean tree to patch this with, so I'm currently pulling a tree on
Linux.  I'll patch it into that tree and check in.

r=javi, sr=cls  (for pedemont@us.ibm.com)
(Assignee)

Comment 7

18 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Did this caues the BeOS breakage or is it just a coincidence?

I can't imagine why it would have.

Comment 9

18 years ago
Yeah it look like it is... Working on finding why now...
In looking at the link line, it looks like it is just getting the cmt, not the 
protocol.

Does BeOs require a tab there?

Comment 11

18 years ago
This line which has been removed from Makefile.in is making BeOS Build to fail

EXTRA_DSO_LDOPTS       += -L$(DIST)/lib -lprotocol

Comment 12

18 years ago
seeing as how the BeOS tinderbox is green and it looks like cls checked in a
fix, I'm going to assume the BeOS problem has been resolved.

verified.
Status: RESOLVED → VERIFIED
(Reporter)

Comment 13

18 years ago
Created attachment 22900 [details] [diff] [review]
updated psm/lib/client/Makefile.in patch
(Reporter)

Comment 14

18 years ago
The above attachment is the proper fix for OS/2, while also keeping 
the EXTRA_DSO_LDOPTS line, whose removal in the first patch broke 
BeOS.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---

Comment 15

18 years ago
r=cls

Comment 16

18 years ago
Sorry about the spam. An unset priority should be less than P5.  
Priority: -- → P5
(Assignee)

Comment 17

18 years ago
Patch checked in.
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED

Comment 18

18 years ago
verified.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.