632103 - remove DO_NOT_START check from runslave.py

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

Since we have a UI to disable slaves, there's no need to add an extra slave-side file to get that effect.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: m632103-puppet-manifests-r1.patch

Remove code.

Comment 2

[[e-mail] (:bhearsum)]

What's the supported way to disable a slave if the allocator is down? Just move the tac file out of the way?

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Yes.

If the slave allocator is down, we should be hard at work getting it back up, anyway, and probably disabling slaves is the least of our worries during that time.  Also, any previously-disabled slaves will stay disabled if the allocator is down.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 510348 [details] [diff] [review]
m632103-puppet-manifests-r1.patch

I think there's still a need to be able to disable slaves when the allocator is down, but creating this file is just as easy as moving the tac out the way, r+.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 510348 [details] [diff] [review]
m632103-puppet-manifests-r1.patch

1099e90f1e1f

Deployed, and I've seen a slave start up on each of the masters, so I think we're good.