632155 - crash [@ gfxWindowsPlatform::GetDLLVersion(unsigned short const*, nsAString_internal&)]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This bug was filed from the Socorro interface and is 
report bp-3c709b34-a9aa-4386-88fe-6c2ab2110206 .
=============================================================

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Seems like this crash could maybe happen if GetFileVersionInfoSizeW returns 0. Although, it's not clear how we would get past VerQueryValue()

Comment 2

[(no longer active)]

(In reply to comment #1)
> Seems like this crash could maybe happen if GetFileVersionInfoSizeW returns 0.
> Although, it's not clear how we would get past VerQueryValue()

While your theory could certainly lead to a crash, I don't think this is what's happening here, since AppendElements(0) would return a pointer to invalid memory, which could lead us crash in either GetFileVersionInfoW or VerQueryValue.  len should be checked against zero after calling VerQueryValue though, since the version entry might exist but have zero size.

Comment 3

[John Daggett (:jtd)]

Attachment: patch, check possible error conditions

Comment 4

[(no longer active)]

Comment on attachment 510524 [details] [diff] [review]
patch, check possible error conditions

Looks great.  I have one nit though: please end the lines with operators instead of beginning new ones with operators.  r=me with that addressed.

Comment 5

[John Daggett (:jtd)]

Landed on trunk
http://hg.mozilla.org/mozilla-central/rev/89e6a9841931