Closed Bug 632165 Opened 14 years ago Closed 14 years ago

initial_rev var written but never read

Categories

(support.mozilla.org :: Knowledge Base Software, task, P2)

Product:
support.mozilla.org
Component:
Knowledge Base Software
Type:
task

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: erik, Assigned: paulc)

Details

(Whiteboard: [qa-])

apps/wiki/views.py:416: local variable 'initial_rev' is assigned to but never used It looks suspicious: if revision_id: initial_rev = get_object_or_404(Revision, pk=revision_id)
Assignee: nobody → james
"Suspicious" is a little dramatic :P This must have slipped into the view from my earliest attempts to fix bug 627174. The fix for that is at line 441, making this superfluous.
Assignee: james → paulc
Target Milestone: 2011Q1 → 2.6
Removed the extraneous 3 lines of code here: https://github.com/jsocol/kitsune/commit/3d21eb80c3ba749b55641989f9f95e0f2b4b14d7
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Closed as [qa-]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.