Closed
Bug 632199
Opened 14 years ago
Closed 14 years ago
mozprofile doesn't clean up temporary add-ons
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ahal, Assigned: k0scist)
Details
(Whiteboard: [mozmill-2.0+])
Attachments
(1 file)
957 bytes,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
If you create a new temporary profile with mozprofile and pass in some add-ons to install, separate folders will be created for each add-on alongside the profile directory: e.g /tmp/tmp5h32dk4.firebug.xpi
While the profile directory gets cleaned up after use, these temporary add-on folders don't.
https://github.com/mozautomation/mozmill/blob/master/mozprofile/mozprofile/profile.py#L204
Assignee | ||
Updated•14 years ago
|
Whiteboard: [mozmill-2.0?]
Assignee | ||
Comment 1•14 years ago
|
||
we certainly want this for 2.0; its a clear bug with an easy fix
Whiteboard: [mozmill-2.0?] → [mozmill-2.0+]
Assignee | ||
Comment 2•14 years ago
|
||
This patch removes the temporary directory for the xpi addons. I can't recall why we don't just unzip directly to the extensions folder, though I recall that being discussed. That would be more efficient, but maybe we don't care right now.
Reporter | ||
Comment 3•14 years ago
|
||
Comment on attachment 512171 [details] [diff] [review]
remove the temporary directory for xpi addons
Works great, r+.
Just out of curiosity, are these getting deleted as soon as they get moved to the profile directory?
Attachment #512171 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Comment 4•14 years ago
|
||
pushed to master: https://github.com/mozautomation/mozmill/commit/6546f3c68250838086e2bbcae893753a0909557e
And yes, the temporary directory is deleted just after copying. Restating, I'm not sure why we just don't unzip directly to the extensions folder
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•