Closed Bug 632224 Opened 13 years ago Closed 1 year ago

HOST_SIMPLE_PROGRAMS should use HOST_LDFLAGS

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86_64
Linux
Type:
defect

Tracking

(firefox109 fixed)

Status:
RESOLVED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox109 --- fixed

People

(Reporter: espindola, Assigned: glandium)

References

Details

Attachments

(2 files)

use HOST_LDFLAGS
2.90 KB, patch
Details | Diff | Splinter Review
Bug 632224 - Add missing HOST_LDFLAGS when linking HOST_SIMPLE_PROGRAMS.
48 bytes, text/x-phabricator-request
Details | Review
Attached patch use HOST_LDFLAGS — — Splinter Review 
When building with LTO and clang it is necessary to pass -use-gold-plugin when liknig.
Do we really care about host programs (typically, programs used when building only) being built with lto ?
Maybe not. I have been building everything with lto so that it is easy to check that it is used (no ELF .o). Once that is done I can try setting HOST_CFLAGS explicitly.
Product: Core → Firefox Build System
Severity: normal → S3
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED

I've hit this while simply wanting to enable lld for host programs, considering we already enable lld everywhere.

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/9754b223499f
Add missing HOST_LDFLAGS when linking HOST_SIMPLE_PROGRAMS. r=firefox-build-system-reviewers,andi
Blocks: 1802271

https://hg.mozilla.org/mozilla-central/rev/9754b223499f

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox109: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: