632279 - Update dehydra to latest spidermonkey (start using compartments)

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Paul Biggar]

Attachment: Add compartment, and fix String creation

To get dehydra to build with the tracemonkey tip, I needed this patch. Tested with `make check_both`.

Comment 1

[(dormant account)]

Comment on attachment 510496 [details] [diff] [review]
Add compartment, and fix String creation

>diff --git a/configure b/configure
>--- a/configure
>+++ b/configure
>@@ -186,16 +186,18 @@ if __name__ == "__main__":
>             jsname = val
>             jsnamels = [jsname]
>         elif o == "--js-libs":
>             jslibs = os.path.expanduser(val)
>         elif o == "--js-headers":
>             jsheaders = os.path.expanduser(val)
>         elif o == "--gcc-build":
>             gcc_build = os.path.expanduser(val)
>+        elif o == "--gcc-src":
>+            gcc_src = os.path.expanduser(val)

You shouldn't need this with 4.5. Headers should be enough.

Comment 2

[Ehren Metcalfe]

Attachment: pbiggar's patch

Just added an include guard for older spidermonkeys without compartments. Stealing review from Taras and will commit as Paul Biggar shortly if there are no objections.

Comment 3

[(dormant account)]

(In reply to comment #2)
> Created attachment 518767 [details] [diff] [review]
> pbiggar's patch
> 
> Just added an include guard for older spidermonkeys without compartments.
> Stealing review from Taras and will commit as Paul Biggar shortly if there are
> no objections.

I object to the elif o == "--gcc-src": bit

Comment 4

[Ehren Metcalfe]

> I object to the elif o == "--gcc-src": bit

took that bit out already

Comment 5

[(dormant account)]

approved then

Comment 6

[Paul Biggar]

Thanks Ehren.

Comment 7

[Ehren Metcalfe]

no prob, http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/514dea3e9c8c