632347 - Expanding a property in the Object Inspector whose type is Generator causes lockup

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Rob Campbell [:rc] (:robcee)]

In the web console, open an Object inspector that contains a Generator. Click the arrow to expand it, browser locks up, beachballs, etc.

Comment 1

[Rob Campbell [:rc] (:robcee)]

see test case at the above URL

Comment 2

[Mihai Sucan [:msucan]]

Attachment: proposed patch

Proposed patch, with fixes for the autocomplete, eval result inspection and for the object inspector panel code. Included a mochitest which checks that the three parts of the Web Console do not fail with iterators and generators. I used the MDN docs to write down the main types of supported iters and gens.

Feedback for improvements is welcome! Thanks!

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 510760 [details] [diff] [review]
proposed patch

+      let str = aResult + "";

toString() ?

f+=me!

Comment 4

[Mihai Sucan [:msucan]]

Attachment: updated patch

Updated the patch. Thanks for the feedback+ Rob!

Asking for review from Shawn.

Comment 5

[Shawn Wilsher :sdwilsh]

Comment on attachment 511336 [details] [diff] [review]
updated patch

>+++ b/toolkit/components/console/hudservice/HUDService.jsm
>+  // Skip Iterators and Generators.
>+  if (typeof obj == "object") {
>+    if (typeof obj.__iterator__ == "function" ||
>+        obj.constructor && obj.constructor.name == "Iterator") {
>+      return null;
>+    }
>+
>+    let str = obj.toString();
>+    if (typeof obj.next == "function" &&
>+        str.indexOf("[object Generator") == 0) {
>+      return null;
>+    }
>+  }
You do this code twice, which means you should pull it into a helper method (like isIteratorOrGenerator(aObject) perhaps)

>+++ b/toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_632347_iterators_generators.js
>@@ -0,0 +1,99 @@
>+/*
>+ * Any copyright is dedicated to the Public Domain.
>+ * http://creativecommons.org/publicdomain/zero/1.0/
>+ *
>+ * Contributor(s):
>+ *   Mihai Èucan <[e-mail]>
>+ */
nit: just https://www.mozilla.org/MPL/boilerplate-1.1/pd-c

r=sdwilsh

Comment 6

[Mihai Sucan [:msucan]]

Attachment: patch update 2

Thanks for the review+ Shawn! Updated the patch as requested.

Comment 7

[Mihai Sucan [:msucan]]

Attachment: [in-devtools] rebased patch

Ready to land (mozilla-central, default branch, on top of bugs 619598 and 618311).

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 521241 [details] [diff] [review]
[in-devtools] rebased patch

checked into devtools

http://hg.mozilla.org/projects/devtools/rev/b224e897c616

Comment 9

[Rob Campbell [:rc] (:robcee)]

http://tinderbox.mozilla.org/showlog.cgi?log=Devtools/1301077938.1301081696.7097.gz&fulltext=1

TEST-PASS | chrome://mochitests/content/browser/toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_632347_iterators_generators.js | iter2 is correctly displayed in the Property Panel
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_632347_iterators_generators.js | window.parent is correctly displayed in the Property Panel
JavaScript strict warning: resource://gre/modules/NetworkPrioritizer.jsm, line 117: reference to undefined property aBrowser.webNavigation
INFO TEST-END | chrome://mochitests/content/browser/toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_632347_iterators_generators.js | finished in 845ms
TEST-INFO | checking window state

Comment 10

[Rob Campbell [:rc] (:robcee)]

disabled test in devtools:

http://hg.mozilla.org/projects/devtools/rev/c8e0ffa5b44b

Comment 11

[Mihai Sucan [:msucan]]

Attachment: test fix for debug builds

This fixes the test in debug builds. Works for me.

It applies cleanly in the devtools repo, default branch.

Comment 12

[Rob Campbell [:rc] (:robcee)]

http://hg.mozilla.org/mozilla-central/rev/b224e897c616

Comment 13

[Simona Badau, Desktop QA]

Verified on:
Build identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.2a1pre) Gecko/20110403 Firefox/4.2a1pre