632388 - Need to offer to restart the browser when extensions are updated

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Kevin Brosnan]

Attachment: extensions window

I looked for a couple extensions I had installed and did not see them. Checked the extension panel and found that they were out of date. I pressed the update button and now each extension reports that a compatibility update has been applied. I don't see a way to restart Fennec from the extensions panel.

Mozilla/5.0 (Android; Linux armv7l; rv:2.0b12pre) Gecko/20110208 Firefox/4.0b12pre Fennec/4.0b5pre ID:20110208042420

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Wes - I thought we did offer a restart if the compatibility update actually required one.

Comment 2

[Wesley Johnston (:wesj)]

I think we do. Most compatibility updates actually involve nothing. We get them because the addon site sent an updates.xml file which basically said "This version of the addon is compatible", even if it already was compatible.

We should probably show nothing unless there is a need to restart, or unless the addon is changing state from incompatible to compatible. I looked at it a bit in bug 627950.

Comment 3

[Wesley Johnston (:wesj)]

Hmm... I didn't read the first post very closely enough. Let me look at this a bit more...

Comment 4

[Wesley Johnston (:wesj)]

Attachment: WIP Patch

Need to figure out a good way to test this.

Comment 5

[Wesley Johnston (:wesj)]

Attachment: Patch v1

Talked to mfinkle about this, and decided that this seemed correct, but wanted to get your opinion Mossop?

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 514326 [details] [diff] [review]
Patch v1

Looks right to me

Comment 7

[Wesley Johnston (:wesj)]

pushed: http://hg.mozilla.org/mobile-browser/rev/cba81a80d503

Comment 8

[Ioana Chiorean]

Using : http://people.mozilla.com/~nhirata/fennec/addons/fennec-sample-a.xpi the restart is performed as expected.

verified fixed with  build id: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre)
Gecko/20110307 Firefox/4.0b13pre Fennec /4.0b6pre

Comment 9

[Ioana Chiorean]

https://litmus.mozilla.org/show_test.cgi?id=15208