632581 - when doing make build_rpms TAG=x-y, refuse to default any tags to tip

Status: RESOLVED FIXED

(Cloud Services :: Server: Other, defect)

Description

[:Atoll]

When any tag is specified, please require all tags to be specified.  This ensures that we don't get a mix of tag and tip when building rpms for production.


"cd server-full; make build_rpms SERVER_CORE=rpm-0.12-1"

should fail, because no tag was provided for the storage/reg components.  And:


"cd server-key-exchange; make build_rpms SERVER_KEY_EXCHANGE=rpm-0.1-3"

should fail, because no tag was provided for the key exchange component.


Please also say which tags are missing, so that we know what to go look up in the changelog.


For developer purposes you may wish to add special handling for the tag name 'tip', to override this check.

Comment 2

[Tarek Ziadé (:tarek)]

Attachment: new builder

Here's a first version of the builder.

1/ implements LATEST_TAGS=1
2/ controls that if you give a tag, you give all of them. Exits if not with info
3/ controls that the given tag really exists. Exits if not.with info
4/ uses a bootstrap that checks for a new version of the builder online if possible, and update the current one

The server-side uses ETags for this.

Comment 3

[Tarek Ziadé (:tarek)]

Attachment: new builder

updated

Comment 4

[:Atoll]

Comment on attachment 511352 [details] [diff] [review]
new builder

python isn't my best language but it seems like this matches the description really well :)  thanks!

Comment 5

[Tarek Ziadé (:tarek)]

Comment on attachment 511352 [details] [diff] [review]
new builder

Let's put JR on this review instead, since Toby is on vacation.

Comment 6

[JR Conlin [:jrconlin,:jconlin]]

Comment on attachment 511352 [details] [diff] [review]
new builder

reviewed as best I can on a phone. looks good.

Comment 7

[Tarek Ziadé (:tarek)]

Done in http://hg.mozilla.org/services/server-key-exchange/rev/0a4bd43adfa6

I am not closing this bug because I need to update other repos servers as well with the new script. Next updates will be automatic.

Comment 8

[Tarek Ziadé (:tarek)]

Done in http://hg.mozilla.org/services/server-full/rev/e3478ce289b1 for full server

Comment 9

[Tarek Ziadé (:tarek)]

Done in http://hg.mozilla.org/services/account-portal/rev/1ce862b585ac for account portal

Comment 10

[Tarek Ziadé (:tarek)]

Done in http://hg.mozilla.org/services/server-identity/rev/f4f78c31a89f for identity.