If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix timestamps for comment data submitted to ElasticSearch

RESOLVED FIXED

Status

Tree Management Graveyard
TBPL
RESOLVED FIXED
7 years ago
3 years ago

People

(Reporter: jgriffin, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
In working on a patch for bug 601743, I discovered I needed to change a little bit of the data that tbpl posts to ElasticSearch for comments.  Specifically, I need to use UTC for the 'date' field, to prevent us from getting a date in some random locale, and I need to add a 'timestamp' field, which is the time that the comment was submitted.
(Reporter)

Comment 1

7 years ago
Created attachment 510828 [details] [diff] [review]
patch
Attachment #510828 - Flags: review?(mstange)
(Reporter)

Updated

7 years ago
Assignee: nobody → jgriffin
Comment on attachment 510828 [details] [diff] [review]
patch

(In reply to comment #0)
> and I need to add a 'timestamp' field, which is the time that
> the comment was submitted.

What's the advantage of taking the current time here instead of on the woo server side?
Attachment #510828 - Flags: review?(mstange) → review+
(Reporter)

Comment 3

7 years ago
(In reply to comment #2)
> 
> What's the advantage of taking the current time here instead of on the woo
> server side?

No advantage; but since I needed to adjust this code to generate a UTC date for the startTime, I decided to add the timestamp here.

Pushed as http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/c929a1420853
Assignee: jgriffin → nobody
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Product: Webtools → Tree Management
(Assignee)

Updated

3 years ago
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.