Validator: Spurious character set warnings while checking l10n-completeness

VERIFIED FIXED in 5.12.11

Status

defect
P3
normal
VERIFIED FIXED
9 years ago
4 years ago

People

(Reporter: nmaier, Assigned: basta)

Tracking

unspecified
5.12.11

Details

(Whiteboard: [ReviewTeam])

Attachments

(2 attachments)

Posted file Test XPI
Unfortunately the switch to fastchardet did not fix the spurious warnings about the encoding, in fact.
Warnings are still raised for a lot of files that are correctly utf-8 encoded.

See the attached XPI:
There should be no charset errors at all, as all locale/*/*.* files are utf-8.
I verified this using the attached python script.
Posted file Python test-script
The warnings are nasty, as they can really confuse add-on authors. They sure confused me when I first encountered them.

I tested against amo-validator master, of course.
Assignee: nobody → mbasta
Severity: major → normal
Priority: -- → P3
Target Milestone: --- → 5.12.11
Fixed

https://github.com/mattbasta/amo-validator/commit/64bab1a4d212f19fbe2aaecae8ef7f123e60027d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
I should note for Kumar that `pip install -r requirements.txt` needs to be run to install fastchardet. Otherwise bad things will happen.
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.